Bug 438542

Summary: Wrong dates on Finnish public holidays
Product: [Frameworks and Libraries] frameworks-kholidays Reporter: Pauli Prokki <pauli.prokki>
Component: generalAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: pauli.prokki, sami.korkalainen
Priority: NOR    
Version: 5.82.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Calendar that shows wrong date
Google Calendar Reference

Description Pauli Prokki 2021-06-13 09:41:58 UTC
Created attachment 139279 [details]
Calendar that shows wrong date

SUMMARY

There is some Finnish public holidays marked as fixed holidays. Example this years midsummer festival "Juhannuspäivä" is showing 19.6.2021 when it supposed to be 26.6.
Also midsummer evening "Juhannusaatto" is showing 18.6.2021 when it suppose to be 25.6.2021

STEPS TO REPRODUCE
1. Digital clock settings > calendars
2. show public holidays
3. holidays > fi_fi Finland Suomen valtakunnalliset juhla- ja liputuspäivät
4. Select 2021 January week 24 day 19
5. shows Juhannuspäivä

OBSERVED RESULT


EXPECTED RESULT
that holidays are not always fixed dates.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux / Plasma
KDE Plasma Version: 5.22.0
KDE Frameworks Version: 5.82.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Comment 1 Pauli Prokki 2021-06-13 09:49:58 UTC
Created attachment 139281 [details]
Google Calendar Reference
Comment 2 Allen Winter 2021-06-13 13:52:15 UTC
Git commit d8497e916b2b9ced0a1f08a2e765c1aad33f1016 by Allen Winter.
Committed on 13/06/2021 at 13:49.
Pushed by winterz into branch 'master'.

holiday_fi_fi - adjust midsummer festival "Juhannuspäivä"

tested the past few years and the upcoming few years according to
https://www.officeholidays.com/holidays/finland/finland-midsummer-day

M  +2    -2    holidays/plan2/holiday_fi_fi

https://invent.kde.org/frameworks/kholidays/commit/d8497e916b2b9ced0a1f08a2e765c1aad33f1016
Comment 3 Allen Winter 2021-06-14 14:43:57 UTC
*** Bug 438619 has been marked as a duplicate of this bug. ***