Bug 438429

Summary:	Digikam freeze whenever I confirm People Tags using a multiple selection with many faces (aprox 20)
Product:	[Applications] digikam	Reporter:	Alessandro Lion <alx241277>
Component:	Faces-Workflow	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	crash	CC:	caulier.gilles, metzpinguin
Priority:	NOR
Version First Reported In:	7.2.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed/Implemented In:	8.2.0
Sentry Crash Report:

Description Alessandro Lion 2021-06-10 16:48:57 UTC

SUMMARY
Digikam freeze whenever I confirm People Tags using a multiple selection with many faces.

STEPS TO REPRODUCE
1. installed on windows 10 not too much ago, version is 7.2.0
2. performed full face detect on a large pictures collection
3. performed manually about 120 people tag with 12 different persons
4. Launched the face recognise and at the end I started to confirm/fix the suggested faces.
5. using shift to select a contiguous block of faces from the thumbnail view when I click on the confimation check button the program freeze for minutes or to undefinite time; once I left the computer on and 70 minutes later it was still not responding before I decided to kill the process and reboot Windows

OBSERVED RESULT
The confirmation on a single person works fine, even on a small multiple selection like 6 at a time.
Whenever I try a bigger lot, 16 or 20 the app freeze and windows report it as no-responding.
Sometimes after waiting an insanely long time it come back but the preview and thumbnails view are no more working and if I try to change view for example from people to albums it stop responding.
In one occasion it come back to work normally for few minutes than become not responding in a definitive way.

EXPECTED RESULT

SOFTWARE/OS VERSIONS
Windows: 10 20H2
macOS:
Linux/KDE Plasma:
(available in About System)
KDE Plasma Version:
KDE Frameworks Version:
Qt Version:

ADDITIONAL INFORMATION

I am working on a homebuilt desktop computer with CPU Phenom II X4 , 12Gb DDR3 RAM, GPU nvidia Geforce 1050 ti and 3 disk drives.
The pictures are on a HDD, unit T:\ , digikam imdb is configured to be saved on a SSD unit S:\ while the Windows System is installed on a different SSD unit C:\
Despite not being a very recent as hardware this computer NEVER EVER freeze with anything I run on it.

Comment 1 Alessandro Lion 2021-06-10 17:13:01 UTC

I realized later it happens only when I select among the People a person with a high number of "news" recognitions to confirm.
I had over 420 news on one person and between 12 and 130 on the others, the only person selection where I could not confirm a high number of pictures at once was that one with the higher number of "news"

Comment 2 Maik Qualmann 2021-06-11 06:40:19 UTC

I cannot reproduce the problem under Winndows. Do you write the face metadata in the images too?
A log of the output from DebugView could help us, as described here:

https://www.digikam.org/contribute/

Don't forget to set the debug environment variable.

You can also test the current developer snapshot of digiKam-7.3.0:

https://files.kde.org/digikam/

Maik

Comment 3 caulier.gilles 2021-12-15 05:07:06 UTC

Alessandro,

Stable digiKam 7.4.0 is published. Please check if problem is reproducible.

https://www.digikam.org/download/

Thanks in advance

Gilles Caulier

Comment 4 Maik Qualmann 2022-10-22 06:42:00 UTC

Git commit 0e0a3bc734e6841ee7c0b40084cd45b7e82ad2c7 by Maik Qualmann.
Committed on 22/10/2022 at 06:36.
Pushed by mqualmann into branch 'master'.

default tag models not sort on face tag counter update
Related: bug 460786, bug 446616, bug 422208

M  +9    -6    core/libs/tags/widgets/tagfolderview.cpp

https://invent.kde.org/graphics/digikam/commit/0e0a3bc734e6841ee7c0b40084cd45b7e82ad2c7

Comment 5 Maik Qualmann 2022-10-22 13:14:07 UTC

Git commit f48d78ecc04ba234f2010792cc679c9ce0c69992 by Maik Qualmann.
Committed on 22/10/2022 at 13:13.
Pushed by mqualmann into branch 'master'.

use a QHash for album and tag counters
Related: bug 460786, bug 446616, bug 422208

M  +2    -1    core/libs/album/manager/albummanager.cpp
M  +12   -12   core/libs/album/manager/albummanager.h
M  +6    -6    core/libs/album/manager/albummanager_album.cpp
M  +11   -11   core/libs/album/manager/albummanager_falbum.cpp
M  +4    -4    core/libs/album/manager/albummanager_p.h
M  +1    -1    core/libs/album/manager/albummanager_palbum.cpp
M  +7    -7    core/libs/album/manager/albummanager_talbum.cpp
M  +14   -14   core/libs/database/coredb/coredb.cpp
M  +6    -6    core/libs/database/coredb/coredb.h
M  +7    -7    core/libs/database/dbjobs/dbjob.cpp
M  +3    -3    core/libs/database/dbjobs/dbjob.h
M  +6    -6    core/libs/database/dbjobs/dbjobsthread.cpp
M  +4    -4    core/libs/database/dbjobs/dbjobsthread.h
M  +2    -2    core/libs/models/abstractalbummodel.h
M  +10   -10   core/libs/models/abstractalbummodel_counting.cpp
M  +14   -3    core/libs/models/albumfiltermodel.cpp
M  +3    -3    core/libs/models/albummodel.cpp
M  +1    -1    core/libs/models/albummodel.h
M  +5    -5    core/libs/models/albummodel_date.cpp
M  +9    -9    core/libs/models/albummodel_tag.cpp
M  +11   -11   core/tests/albummodel/albummodel_utest.cpp
M  +3    -3    core/tests/albummodel/albummodel_utest.h
M  +9    -9    core/tests/database/databasetags_utest.cpp
M  +2    -2    core/tests/database/databasetags_utest.h
M  +2    -2    core/utilities/maintenance/facesdetector.cpp

https://invent.kde.org/graphics/digikam/commit/f48d78ecc04ba234f2010792cc679c9ce0c69992

Comment 6 Maik Qualmann 2022-10-22 13:39:38 UTC

Git commit 447c28157c556387dd9044169b3e882fe6b82c4a by Maik Qualmann.
Committed on 22/10/2022 at 13:36.
Pushed by mqualmann into branch 'master'.

optimize tag counter update in the model
Related: bug 460786, bug 446616, bug 422208
FIXED-IN: 8.0.0

M  +2    -2    NEWS
M  +1    -1    core/libs/models/abstractalbummodel.h
M  +9    -11   core/libs/models/abstractalbummodel_counting.cpp

https://invent.kde.org/graphics/digikam/commit/447c28157c556387dd9044169b3e882fe6b82c4a

Comment 7 Maik Qualmann 2022-10-22 13:49:52 UTC

Git commit 94c6c851bb1608ae7fd16ea2a60c72b21fc91faa by Maik Qualmann.
Committed on 22/10/2022 at 13:49.
Pushed by mqualmann into branch 'qt5-maintenance'.

backport from master the main tag counter fix
Related: bug 460786, bug 446616, bug 422208

M  +9    -11   core/libs/models/abstractalbummodel.cpp
M  +1    -1    core/libs/models/abstractalbummodel.h
M  +9    -6    core/libs/tags/widgets/tagfolderview.cpp

https://invent.kde.org/graphics/digikam/commit/94c6c851bb1608ae7fd16ea2a60c72b21fc91faa

Comment 8 caulier.gilles 2023-04-19 14:47:02 UTC

@Alessandro

digiKam 8.0.0 is out. Problem still reproducible ?

Best regards
Gilles Caulier

Comment 9 caulier.gilles 2023-10-15 10:09:21 UTC

@Alessandro,


This problem still reproducible with the new digiKam 8.2.0 pre-release Windows
installer available at usual place:

https://files.kde.org/digikam/

This new bundle is based on last Qt framework 5.15.11 and KDE framework 5.110.

Thanks in advance

Gilles Caulier

Comment 10 caulier.gilles 2023-11-19 17:07:20 UTC

This crash is not reproducible with digiKam compiled under Windows with
VCPKG. digiKam 8.2.0 pre-release installer is here :

https://files.kde.org/digikam/unstable/

Gilles Caulier