| Summary: | Animation curves - Rotation with Transform Mask - Glitches | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | grum999 |
| Component: | Animation | Assignee: | Eoin O'Neill <eoinoneill1991> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | eoinoneill1991, tamtamy.tymona |
| Priority: | NOR | Keywords: | release_blocker |
| Version: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/ba10b857f963edc2467324b338d23af76d5c6d58 | Version Fixed In: | |
| Attachments: | fe16ff7_result_example | ||
|
Description
grum999
2021-06-09 17:24:32 UTC
Could you please specify what your Animation Cache settings are like currently? How may CPU cores you have dedicated to caching, for example. Hi - CPU limit: 18 (of 24) - Frame rendering clone limit: 1 (of 24) >but problem also occurs with any value - Cache storage backend: in-memory >but problem also occurs with 'on-disk' - Limit cached frame size: CHECKED (2500px) - Use region of interest: UNCHECKED (25%) >but problem also occurs with CHECKED value - Enable background cache generation: UNCHECKED - Memory limit: 60GiB (of 64GiB) - Swap undo after: 999MiB - Swap file size limit: 64GiB --- Note: concerning value of 'Frame rendering clone limit', I usually set it to 1 because of other bugs encountered with higher value One interesting thing I saw this morning. Going to a frame, render is corrupted. But, if you stay on frame, 4-5s after render is updated automatically and properly made. The delay reminds me this bug comment: https://bugs.kde.org/show_bug.cgi?id=436642#c2 Don't know if it can help or not, if this '4second' delay is related or not... The other bug was related to transform mask too Grum999 I think what might be happening is that old transform data is being updated ontop of the already precalculated cached image. I'll look at it more next week. Git commit b347ab13a326fc571c6ff6e1f51f515c3e5d5a78 by Eoin O'Neill. Committed on 30/06/2021 at 02:47. Pushed by eoinoneill into branch 'master'. Prevent recalculate transform mask job from interrupting animation playback. M +3 -1 libs/image/kis_recalculate_transform_mask_job.cpp https://invent.kde.org/graphics/krita/commit/b347ab13a326fc571c6ff6e1f51f515c3e5d5a78 Created attachment 139876 [details]
fe16ff7_result_example
Hi
Just downloaded and tested Linux appimage krita-5.0.0-prealpha-fe16ff7-x86_64.appimage
Nothing changed on my side: rendered frames with transform mask still generate glitches
I reopen bug.
Grum999
Yeah, there still seems to be some bugs with off centered rotations... Git commit ba10b857f963edc2467324b338d23af76d5c6d58 by Eoin O'Neill. Committed on 08/07/2021 at 05:43. Pushed by eoinoneill into branch 'master'. Fixed threading issue with animated transform masks with non-centered rotations. M +2 -6 plugins/tools/tool_transform2/kis_animated_transform_parameters.cpp M +0 -2 plugins/tools/tool_transform2/kis_animated_transform_parameters.h https://invent.kde.org/graphics/krita/commit/ba10b857f963edc2467324b338d23af76d5c6d58 Please try it again when you get some time. I think the glitchy rotations should be mostly resolved now. Reopen if you come across any additional edge-cases. (In reply to Eoin O'Neill from comment #9) > Please try it again when you get some time. I think the glitchy rotations > should be mostly resolved now. Reopen if you come across any additional > edge-cases. Tested on krita-5.0.0-prealpha-ebe5933-x86_64.appimage, I can confirm that there's no glitch anymore :) Grum999 |