Bug 438317

Face detection/recognition is an integral part of digiKam, the download is necessary, the binary files must be available. We also cannot simply deactivate it as it is linked to many components in digiKam. In the past you always downloaded the files in the bundle with each new digiKam version. Now all you have to do is do it one more time.

Maik

(In reply to Maik Qualmann from comment #1)
> Face detection/recognition is an integral part of digiKam, the download is
> necessary, the binary files must be available. We also cannot simply
> deactivate it as it is linked to many components in digiKam.
Yes but after deactivating it at each startup, digikam works normally without it. That's why i think message at startup could be an option. 

> In the past you
> always downloaded the files in the bundle with each new digiKam version. Now
> all you have to do is do it one more time.
I used bundle one or two times, just to test. I don't know if these binaries were in git master source code or/and compiled packages.

(In reply to maderios from comment #2)
> Yes but after deactivating it at each startup, digikam works normally
> without it. That's why i think message at startup could be an option.

Yes, digiKam would crash if you started face recognition, I have to fix it.
 
> I used bundle one or two times, just to test. I don't know if these binaries
> were in git master source code or/and compiled packages.

Yes, the binary files were recently part of the source archive, it was 1GB in size and the KDE admins didn't like it either.

Maik

Another bad thing with such feature implementation that it breaks package manager use experience in Linux distros. When you install digikam via  package manager you suppose that you can run the application. Even without the Internet.

Please, consider to make possible for the use to switch off this option on the first start.

The dialog can be canceled, it will be displayed again at the next start. Other applications also download data that are not installed with the package manager, e.g. Marble, which is also included in digiKam. This download saves downloading several 100 MB with every new digiKam version.

Maik

> The dialog can be canceled, it will be displayed again at the next start. 
Yes, but it pretty annoys if you don't want to download it. Like shareware banners in the early 2000s.

> Other applications also download data that are not installed with the package manager
It is not really common in the world of linux distro package managers. E.g. if you install it with `dnf install digikam` it should simply run. And it was so for digikam sometime ago.

> This download saves downloading several 100 MB with every new digiKam version.
It's clear and good purpose but there are people who don't want do download anything against the linux distro repository package. Plus some don't use Face detection feature at whole.

Git commit 67235cd937a355e0b636be45fae304135f76ce25 by Maik Qualmann.
Committed on 08/02/2022 at 21:38.
Pushed by mqualmann into branch 'master'.

fix crash when face data is missing

M  +5    -0    core/libs/facesengine/preprocessing/recognition/openfacepreprocessor.cpp

https://invent.kde.org/graphics/digikam/commit/67235cd937a355e0b636be45fae304135f76ce25

As a user new to Digikam, I find the "download at first launch" to be pretty poor UX, all things considered.

If these components really are core features of Digikam (and I think they are), then they should be packaged into the Digikam installer.  The built-in downloader doesn't seem to work very well (I am having trouble getting it to not continually try to download from non-functional KDE mirrors) and seems like a case of misplaced optimization.

Bandwidth is cheap. Users' time is expensive.  I have already spent far more time sitting in front of my computer, continually clicking on "Try Again", than it would have taken just to include these extra files in the core installer that I downloaded when I decided I wanted to try Digikam.  To save someone some theoretical bandwidth when upgrading, the process has instead wasted my time.  This doesn't seem great.

Furthermore, it's not even clear to me that this design actually saves bandwidth. It does in one particular case (that of upgrades, apparently), but would be strongly counterproductive if you were, say, installing a whole lab's worth of computers with Digikam. There, you'd want to download the installer once, distribute it locally, and install it on each machine. Having each machine then go online and download the same files over and over isn't great. I suspect a case like this (where the installer is passed around locally via removable media, file shares, etc.) is pretty common in low-bandwidth environments.

It's annoying and a poor introduction to Digikam for new users, wastes human time, isn't especially reliable, and the benefit to users with limited-bandwidth connections seems arguable at best. Definite misfeature, IMO.

There is no way around downloading it. When some files were still part of the source code, the KDE admins recommended us to look for another way since the source archive was already reaching 1GB. Certainly like in the Windows installer and MacOS package and AppImage could include these files. But Windows users in particular have described the large installer as "deterrent" in forums. Also consider that high bandwidth is not available in all regions of the world to have to download it with every new version.

Maik

Git commit 33d3792539af018877063879877bf3fb26942088 by Maik Qualmann.
Committed on 09/02/2022 at 07:38.
Pushed by mqualmann into branch 'master'.

prevent openCV exceptions with missing face data

M  +2    -1    core/libs/facesengine/detection/opencv-dnn/dnnfacedetectoryolo.cpp

https://invent.kde.org/graphics/digikam/commit/33d3792539af018877063879877bf3fb26942088

> There is no way around downloading it.
...
> Yes, digiKam would crash if you started face recognition, I have to fix it.

What about moving dialog  "Download Requires Files ..." to this exception handling? So user can start digikam without asking to download heavy external blobs and will do it if he really want to use this feature.

Note : NSIS packager for Windows that we use is limited to 32 bits and cannot package more than 2Gb of data in one exe file.
this is problematic to provide a debug symbols version which explode by 5-10 the size of binary. If we host DNN model files in installer, I'm sure that we will have a problem. NSIS provide a solution for big data but this require to rewrite and test the NSIS script and to include an extra plugin DLL. An i'm against to do it for security reasons. 

Gilles Caulier

A non blocking message as one used with fuzzy search about to build finger-prints is the better solution.

But the face engine code must be more mature to resist of a start of face algorithms if data model files are not present. This case is simple : user refuse to download big data model and start face detection for ex.

Gilles Caulier

Git commit 415b83c594cbe56aa948cfe380a00b9b19d729aa by Maik Qualmann.
Committed on 09/02/2022 at 17:34.
Pushed by mqualmann into branch 'master'.

prevent openCV exceptions with missing face data #2

M  +2    -1    core/libs/facesengine/recognition/opencv-dnn/dnnfaceextractor.cpp

https://invent.kde.org/graphics/digikam/commit/415b83c594cbe56aa948cfe380a00b9b19d729aa

What about solution similar to how wine handles it's gecko and mono packages? They can be installed system-wide using package manager, or automatically during first startup. The face recognition data can be released separately from digiKam.

* the face recognition data would be released separately from digiKam, so they don't have to be updated with every digiKam release
* digikam would have to check both system folder and user folder
* nice to have: have the notification less obtrusive, something like the notifications in kate eg. when you reload a file.
* nice to have #2: if the files are not available, disable the affected functionality and notify user that they need the data when they try to use it.

This would improve at least the following use cases:
* users that manage multiple computers would download the system-wide package once and install it everywhere
* shared computers - the system-wide package would need to be installed only once rather than for every user
* users of linux distros that prefer to use packages to download&install stuff
* windows users and any other users that doesn't care about downloading data separately would download the data on startup if they wanted to
* in the system-wide install scenarios, digiKam updates would not require re-downloading the data, because they would be released separately

I have to agree with the other comments. I just googled 'disable digikam binary download' and ended up here. Couldn't we have  a checkbox by the Cancel button that says like 'dont ask me again' ?

An opensource photo manager downloading stuff without asking, from who knows what site, just feels wrong. Doing it through the disto package manager would be so much better. I've used digiKam for many years and I have never used the face detection or redeye stuff. No offense, thanks for all your hard work on this software.

*** Bug 452892 has been marked as a duplicate of this bug. ***

Git commit d5c910dabfdbfafd1f7205b0fbecbd362d7f52a8 by Maik Qualmann.
Committed on 25/04/2022 at 19:41.
Pushed by mqualmann into branch 'master'.

add "don't ask me again" option to the face data downloader
In the digiKam system settings there is a button to
start the downloader dialog manually.

M  +9    -7    core/app/main/main.cpp
M  +9    -5    core/showfoto/main/main.cpp
M  +17   -1    core/utilities/setup/downloader/filesdownloader.cpp
M  +7    -8    core/utilities/setup/system/systemsettings.cpp
M  +2    -1    core/utilities/setup/system/systemsettings.h
M  +41   -16   core/utilities/setup/system/systemsettingswidget.cpp
M  +4    -0    core/utilities/setup/system/systemsettingswidget.h

https://invent.kde.org/graphics/digikam/commit/d5c910dabfdbfafd1f7205b0fbecbd362d7f52a8

*** Bug 454580 has been marked as a duplicate of this bug. ***

Git commit ec132502dcbc91aaab75acda390b7109533ffb82 by Maik Qualmann.
Committed on 06/05/2023 at 11:52.
Pushed by mqualmann into branch 'master'.

make face engine data centralizable

M  +7    -8    core/libs/dimg/filters/redeye/redeyecorrectionfilter.cpp
M  +6    -7    core/libs/facesengine/detection/opencv-dnn/dnnfacedetectorssd.cpp
M  +6    -7    core/libs/facesengine/detection/opencv-dnn/dnnfacedetectoryolo.cpp
M  +6    -7    core/libs/facesengine/preprocessing/recognition/openfacepreprocessor.cpp
M  +8    -9    core/libs/facesengine/recognition/opencv-dnn/dnnfaceextractor.cpp
M  +6    -6    core/libs/imgqsort/detectors/aesthetic_detector.cpp
M  +16   -6    core/utilities/setup/downloader/filesdownloader.cpp

https://invent.kde.org/graphics/digikam/commit/ec132502dcbc91aaab75acda390b7109533ffb82

Git commit cd62301502194c2d31b85c8b03a4e91609affafd by Maik Qualmann.
Committed on 04/12/2023 at 23:31.
Pushed by mqualmann into branch 'master'.

give the user the choice of which features they want to use and download
FIXED-IN: 8.3.0

M  +1    -1    NEWS
M  +1    -1    core/app/main/main.cpp
M  +1    -1    core/showfoto/main/main.cpp
M  +190  -124  core/utilities/setup/downloader/filesdownloader.cpp
M  +3    -0    core/utilities/setup/downloader/filesdownloader.h
M  +30   -9    core/utilities/setup/misc/systemsettings.cpp
M  +5    -1    core/utilities/setup/misc/systemsettings.h
M  +2    -2    core/utilities/setup/misc/systemsettingswidget.cpp

https://invent.kde.org/graphics/digikam/-/commit/cd62301502194c2d31b85c8b03a4e91609affafd