Bug 438269

Summary: Filter -> Blur has no chain button any more (no way to adjust values separately)
Product: [Applications] krita Reporter: Tiar <tamtamy.tymona>
Component: FiltersAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: ahab.greybeard, ginoba
Priority: NOR Keywords: regression
Version First Reported In: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Mint (Ubuntu based)   
OS: Linux   
Latest Commit: https://invent.kde.org/graphics/krita/commit/06d2270b77c3681edfa783ab006b765c7772be93 Version Fixed/Implemented In:
Sentry Crash Report:

Description Tiar 2021-06-08 16:18:07 UTC 
SUMMARY
Filter -> Blur lost its chain button.

STEPS TO REPRODUCE
1. Go to Filter -> Blur.

OBSERVED RESULT
No chain button, so there is no way to adjust values separately.

EXPECTED RESULT
Chain button like it was in 4.4.3.

SOFTWARE/OS VERSIONS
Krita

 Version: 5.0.0-prealpha (git 4d6e567)
 Languages: pl, pl_PL, pl
 Hidpi: true

Qt

  Version (compiled): 5.12.8
  Version (loaded): 5.12.8

OS Information

  Build ABI: x86_64-little_endian-lp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: linux
  Kernel Version: 5.4.0-58-generic
  Pretty Productname: Linux Mint 20.1
  Product Type: linuxmint
  Product Version: 20.1
  Desktop: X-Cinnamon
Comment 1 Ahab Greybeard 2021-06-08 20:32:07 UTC 
I can confirm this for the Jun 08 5.0.0-prealpha (git 8944b0f) appimage.
Comment 2 Deif Lou 2021-06-08 21:56:10 UTC 
The button is there for me, but it has no icon initially, so being it flat, it is not noticeable.
Comment 3 Ahab Greybeard 2021-06-09 05:34:38 UTC 
As per Comment 2, if you hover the cursor over it, an empty rectangle appears.
When clicked, the chain icon appears and is visible from then on while the Filter:Blur window is open.
The next time it's opened, the button and icon are not visible until hover or click.

Other chain buttons have similar behaviour of the button background but the chain icon is always visible.

Additional Note: For the Selection tool Tool Options, the lock symbols are not visible unless they are active but their button background is always visible.
Comment 4 Dmitry Kazakov 2021-07-21 06:46:38 UTC 
Git commit 06d2270b77c3681edfa783ab006b765c7772be93 by Dmitry Kazakov.
Committed on 21/07/2021 at 06:44.
Pushed by dkazakov into branch 'master'.

Fix aspect button initialization in Blur filter

The bug was caused by a coincidence of four problems:

1) KoAspectButton never did initialization of the icon in the constructor,
   it waited for someone to call setKeepAspectRatio() to set up the icon

2) Constructor of KisWdgBlur never initialized m_halfSizeLink variable
   and the button.

3) [not fixed] KisWdgBlur::setConfiguration() (and a lot of other filters) just skip
   initializing the GUI control in case the property is absent in the
   configuration. Ideally, it should fall back to the default value
   instead.

4) KisBlurFilter::defaultConfiguration() didn't add a property for
   "lockAspect", so the control has never been initialized unless the
   user clicked on it.

M  +7    -4    libs/widgets/KoAspectButton.cpp
M  +1    -0    plugins/filters/blur/kis_blur_filter.cpp
M  +3    -0    plugins/filters/blur/kis_wdg_blur.cpp

https://invent.kde.org/graphics/krita/commit/06d2270b77c3681edfa783ab006b765c7772be93