Bug 438226

Summary:	separators in global drawer render wrong on mobile
Product:	[Frameworks and Libraries] frameworks-kirigami	Reporter:	Nicolas Fella <nicolas.fella>
Component:	general	Assignee:	Marco Martin <notmart>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate
Priority:	NOR
Version First Reported In:	Master
Target Milestone:	Not decided
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/frameworks/kirigami/-/commit/88471e76e75efc4b2e68f4425a9fbc8dd4d95c49	Version Fixed/Implemented In:	5.109
Sentry Crash Report:
Attachments:	Screenshot

Description Nicolas Fella 2021-06-07 20:31:27 UTC

Consider the code at https://invent.kde.org/utilities/ktrip/-/blob/master/src/qml/main.qml#L46

On the desktop the separator is a thin line between the items in the menu

On mobile the separator is an item the size of the other items with half of a thin line. It should be just a thin like like on the desktop

Comment 1 Nicolas Fella 2021-06-07 20:33:11 UTC

Created attachment 139094 [details]
Screenshot

Comment 2 Bug Janitor Service 2023-07-18 06:18:41 UTC

A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1182

Comment 3 Nate Graham 2023-07-18 06:24:36 UTC

Git commit 88471e76e75efc4b2e68f4425a9fbc8dd4d95c49 by Nate Graham.
Committed on 18/07/2023 at 06:12.
Pushed by carlschwan into branch 'master'.

Unbreak separator actions

Because the icon and text items were not hiding themselves, they were
taking up space that showed nothing, causing the separator item to be
too narrow and take up too much vertical space.
FIXED-IN: 5.109

M  +2    -1    src/controls/private/GlobalDrawerActionItem.qml

https://invent.kde.org/frameworks/kirigami/-/commit/88471e76e75efc4b2e68f4425a9fbc8dd4d95c49