Bug 438209

Summary: On macOS, bundles cannot be opened
Product: [Applications] krita Reporter: Halla Rempt <halla>
Component: Resource ManagementAssignee: vanyossi <ghevan>
Status: RESOLVED FIXED    
Severity: normal CC: ghevan, l2dy, tamtamy.tymona
Priority: NOR Keywords: regression, release_blocker
Version: nightly build (please specify the git hash!)   
Target Milestone: ---   
Platform: Other   
OS: Other   
Latest Commit: Version Fixed In:
Attachments: commandline output

Description Halla Rempt 2021-06-07 13:36:05 UTC
Created attachment 139076 [details]
commandline output

On macOS, both mojave and big sur, krita cannot open the bundles.
Comment 1 Halla Rempt 2021-06-14 13:25:41 UTC
This is because the paintop plugins are created the wrong way, so they don't link as a result of:

commit f862034e93a62fd2538fde0efece9310e99abbf2
Author: Ivan Yossi <ghevan@gmail.com>
Date:   Tue Apr 27 12:53:18 2021 -0500

    Build libs for tests as SHARED instead of MODULE
    
    In theory on Linux this should not change anything, but on macos
    it allows us to dynamic link tests to this libs, and remove build
    errors when building with tests ON.
Comment 2 vanyossi 2021-06-14 17:09:05 UTC
Git commit 6313add0a223b9487132bbcc52a791a5b2fbf0ac by Ivan Yossi.
Committed on 14/06/2021 at 17:07.
Pushed by ivany into branch 'master'.

Revert "Build libs for tests as SHARED instead of MODULE"

This reverts commit f862034e93a62fd2538fde0efece9310e99abbf2.

M  +1    -5    plugins/dockers/animation/CMakeLists.txt
M  +3    -7    plugins/dockers/storyboarddocker/CMakeLists.txt
M  +1    -6    plugins/paintops/defaultpaintops/CMakeLists.txt
M  +1    -5    plugins/paintops/mypaint/CMakeLists.txt

https://invent.kde.org/graphics/krita/commit/6313add0a223b9487132bbcc52a791a5b2fbf0ac