| Summary: | Quick Settings page gets truncated when the resolution is low | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Lua <lv215bd5> |
| Component: | Quick Settings | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version: | 5.22.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/commit/3465955554beb28b05644fbfe6e891cb3fe17442 | Version Fixed In: | 5.22.2 |
| Sentry Crash Report: | |||
| Attachments: | No scrollbar | ||
|
Description
Lua
2021-06-06 18:08:21 UTC
Created attachment 139077 [details]
No scrollbar
Ugh I had hoped this would never happen. :/ A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/501 Git commit c561706fed003b1746223a1c25cc4b476c835082 by Méven Car, on behalf of Nate Graham. Committed on 20/06/2021 at 09:57. Pushed by ngraham into branch 'master'. [kcms/landingpage] Give up on vertical centering and let it scroll In the past, we made the content view of this KCM center vertically. However that caused binding loops and made resizing slow. Then later we made it non-scrollable so that it could be vertically centered, but that broke scrollability for users with very short screens. This commit simplifies the situation to stop doing anything fancy at all and just uses a boring old SimpleKCM. This lets it be scrollable but does not have vertical centering for the content. However no other KCM vertically centers its content like this anyway, so arguably there is a consistency win as well. FIXED-IN: 5.21.2 M +1 -14 kcms/landingpage/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-desktop/commit/c561706fed003b1746223a1c25cc4b476c835082 Git commit 3465955554beb28b05644fbfe6e891cb3fe17442 by Nate Graham. Committed on 20/06/2021 at 13:43. Pushed by ngraham into branch 'Plasma/5.22'. [kcms/landingpage] Give up on vertical centering and let it scroll In the past, we made the content view of this KCM center vertically. However that caused binding loops and made resizing slow. Then later we made it non-scrollable so that it could be vertically centered, but that broke scrollability for users with very short screens. This commit simplifies the situation to stop doing anything fancy at all and just uses a boring old SimpleKCM. This lets it be scrollable but does not have vertical centering for the content. However no other KCM vertically centers its content like this anyway, so arguably there is a consistency win as well. FIXED-IN: 5.21.2 (cherry picked from commit c561706fed003b1746223a1c25cc4b476c835082) M +1 -14 kcms/landingpage/package/contents/ui/main.qml https://invent.kde.org/plasma/plasma-desktop/commit/3465955554beb28b05644fbfe6e891cb3fe17442 |