Bug 438134

Summary:	Unexpected behaviour of face overlay in preview window
Product:	[Applications] digikam	Reporter:	lesf
Component:	Usability-Overlay	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, metzpinguin
Priority:	NOR
Version First Reported In:	7.3.0
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/digikam/commit/55af44eca3d3484369fe6b3dd2f81c8a3d0e9664	Version Fixed/Implemented In:	7.3.0
Sentry Crash Report:

Description lesf 2021-06-05 20:37:02 UTC

I'm using the face tags in the preview window.

1. case: there is a suggestion from face detection in the text field.
Tool tip of remove button shows "Reject this suggestion".
Expected behaviour: text field is cleared? (not sure whether I would expect this). However, the face rectangle should be kept!
Observed behaviour: face rectangle is removed -- this is in contrast to the tool tip.

2. case: there is no suggestion from face detection in the text field.
Tool tip of remove button shows "Mark this face as Ignored"
Expected behaviour: face gets the "Ignored" virtual tag, shows up under "Ignored"
Observed behaviour: face rectangle is removed -- this is in contrast to the tool tip.

3. case: select "People" > "Ignored" tag, click on one face to open preview window
Face overlay is in "compact mode", tool tip of the check button shows "Unmark this face as Ignored"
Expected behaviour: complete face overlay is shown (with text field), the face is moved from "Ignored" to "Unknown".
Observed behaviour: face rectangle is removed -- this is in contrast to the tool tip.


From usability point of view, it shouldn't matter whether the face confirmation/rejection/ignoring is operated in the people view or in the preview window.
If this is difficult to implement, at least the tool tips should show the correct behaviour. For the cases outlined above this would be "remove face rectangle" or similar.

Comment 1 caulier.gilles 2021-06-06 03:40:15 UTC

This problem still reproducible with 7.3.0 re-release bundle ?

https://files.kde.org/digikam/

Gilles Caulier

Comment 2 lesf 2021-06-06 08:54:18 UTC

I can confirm the described behaviour for digiKam-7.3.0-20210605T170945-x86-64.appimage.

Comment 3 Maik Qualmann 2021-06-06 14:15:05 UTC

The various tooltips were added as part of GSoC2020 while working on the face engine. I have now implemented it as a test, as it was intended. But stepping back from confirmed-> unconfirmed-> ignored face is really bad for the manual face item in the preview mode of using only one button. We will leave the button to a simple remove of the face region.

Maik

Comment 4 Maik Qualmann 2021-06-06 20:45:54 UTC

Git commit 55af44eca3d3484369fe6b3dd2f81c8a3d0e9664 by Maik Qualmann.
Committed on 06/06/2021 at 20:44.
Pushed by mqualmann into branch 'master'.

fix tooltip from preview widget face region remove button
Use a clickable ignored label in the preview widget.
Ignored faces can be changed back to unknown faces.
FIXED-IN: 7.3.0

M  +3    -1    NEWS
M  +18   -0    core/app/items/overlays/assignnameoverlay.cpp
M  +2    -0    core/app/items/overlays/assignnameoverlay.h
M  +25   -0    core/app/items/views/digikamitemview.cpp
M  +8    -3    core/app/items/views/digikamitemview.h
M  +11   -0    core/utilities/facemanagement/items/facegroup.cpp
M  +1    -0    core/utilities/facemanagement/items/facegroup.h
M  +3    -0    core/utilities/facemanagement/items/facegroup_p.cpp
M  +7    -1    core/utilities/facemanagement/widgets/assignnamewidget.cpp
M  +6    -0    core/utilities/facemanagement/widgets/assignnamewidget.h
M  +56   -19   core/utilities/facemanagement/widgets/assignnamewidget_p.cpp
M  +3    -2    core/utilities/facemanagement/widgets/assignnamewidget_p.h

https://invent.kde.org/graphics/digikam/commit/55af44eca3d3484369fe6b3dd2f81c8a3d0e9664