Bug 438031

Summary: Ksysguard assumes static folder structure for lmsensors and it breaks the functionality
Product: [Unmaintained] ksysguard Reporter: Ville Aakko <ville.aakko>
Component: ksysguardAssignee: KSysGuard Developers <ksysguard-bugs>
Status: RESOLVED UNMAINTAINED    
Severity: normal CC: d.schlabing, plasma-bugs
Priority: NOR    
Version: 5.21.5   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Ville Aakko 2021-06-03 13:03:01 UTC 
KSysGuard assumes static names for lmsensors sensor file name and folder structure. This is not a safe assumption since a driver providing sensors might not have the same exact name on every boot.

I have an USB connected sensor device (Corsair Commander Pro using the corsaircpro driver), and on every boot, it get's populated to a different part in the USB tree. (such as: corsaircpro-hid-3-6, corsaircpro-hid-3-8, corsaircpro-hid-3-4 etc.)

I'm not sure how to fix this easily. Perhaps using some kind of wild card in the name entry? We could parse /sys/class/hwmon/hwmon?/name, but that should be an option. This approach would fix this for me on current setup, since all my devices are named differently, but will break it for others, as there can be many hwmon? with the same name (see an old, now closed bug report: https://bugs.kde.org/show_bug.cgi?id=107941). Perhaps there could be an option which way the sensor device is dentified - the lmsensors short name (only) or the full devid path (the current way)?

Note: on my system the device is in a different part of the usb tree, despite the said device has been plugged in all the time.

STEPS TO REPRODUCE
1. Have a device which doesn't get the same name every boot (as output by the sensors command or identified by ksysguard - lmsensors/[NAME]/sensor)
2. Add sensors from this device in KSysguard
3. Reboot and restart KSysGuard

OBSERVED RESULT

KSyaGuard does not find previously assigned sensors in it's graphs (despite lmsensors having picked them up), if the device name has changed from previous boot. Instead KSysGuard reports an error for the sensor.

EXPECTED RESULT

KSysGuard should find all sensors previously assigned to a graph

SOFTWARE/OS VERSIONS

Operating System: Arch Linux
KDE Plasma Version: 5.21.5
KDE Frameworks Version: 5.82.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION:
This kind of problems mighty become more common, as H/W sensors become more commonplace in many different kind of devices. Around a decade ago, I had 1-2 sensor providing devices - now I have 7! Perhaps some kind of rethinking / overhaul is needed for the sensor finding?
Comment 1 Christoph Cullmann 2024-09-23 20:59:52 UTC 
ksysguard is no longer maintained, in Plasma 6 there is the Plasma system monitor for this task.

If your issue still happens with the Plasma 6 replacement, please re-open and we can move this bug to the new product, thanks!
Comment 2 Ville Aakko 2024-09-28 09:46:39 UTC 
(In reply to Christoph Cullmann from comment #1)
> ksysguard is no longer maintained, in Plasma 6 there is the Plasma system
> monitor for this task.
> 
> If your issue still happens with the Plasma 6 replacement, please re-open
> and we can move this bug to the new product, thanks!

Hi,

Yes, this still applies to System Monitor (and probably Applets, since both use ksystemstats, but I haven't tested).

I've already reported a separate issue #466277.

Since there's a separate issue already reported and ksysguard is unmaintained (and I gather this will never be fixed) then I suppose the state of the issue can be left as resolved/unmaintained.