Bug 437755

Summary:	(Feature Request) Changing colors configuration and Dark icons
Product:	[Applications] okular	Reporter:	Victor <murilo.sc.sc>
Component:	general	Assignee:	Okular developers <okular-devel>
Status:	RESOLVED FIXED
Severity:	minor	CC:	laura.stern, nate
Priority:	NOR
Version:	1.9.3
Target Milestone:	---
Platform:	Mint (Ubuntu based)
OS:	Linux
Latest Commit:	https://invent.kde.org/graphics/okular/commit/195bbe3636155613555c27f4e67d21aa1461a5b6	Version Fixed In:	21.08
Sentry Crash Report:

Description Victor 2021-05-27 23:55:45 UTC

Using Okular was a game changer for me, as I have the possibility to use the interface of Okular in dark themed mode (thanks also to using Linux, one of the reasons I dumped Windows) and also the possibility of easily changing document colors. This makes a whole lot difference for someone who stays all day, 10+ hours, in front of a screen reading PDFs. At night, I don't have headaches anymore.

I started doing this by inverting colors, I don't know the reason, but it was not entirely confortable, so I tried changing dark and light colors of the PDFs. I change Light colors to Dark Grey, and dark colors from the pdf as very light yellow and haven't ever tried something else. This eliminates any eyestrain.

But I have one problem: I'm currently doing a PhD in a STEM related field, and sometimes it is necessary to see colors in figures. The solution available right now is to use a hotkey or a button on tool's bar that disables color changes to default (white background and black print). It would be significantly better if one could, by a button on tool's bar, to swap from changing dark and light colors to invert colors, avoiding a big contrast of dark and bright colors available right now.

This could be more easily implemented by adding a hierarchy to colors, setting it up on Configurations the first color option, then a secundary color option, so that when the "change colors" button on tool's bar it changes to the secondary color option.

Also, It would be more aesthetically pleasing if dark icon had better colors (they are barely visible right now) when in the OS's dark mode (panel on dark colors).

Thanks in advance.
Victor.

EXPECTED RESULT

SOFTWARE/OS VERSIONS
Windows:
macOS:
Linux/KDE Plasma:
(available in About System)
KDE Plasma Version:
KDE Frameworks Version:
Qt Version:

ADDITIONAL INFORMATION

Comment 1 Laura David Hurka 2021-05-28 17:40:16 UTC

> Also, It would be more aesthetically pleasing if dark icon had better
> colors (they are barely visible right now) when in the OS's dark
> mode (panel on dark colors).

Which icon? The Okular application icon? Anyway, that is a different issue, the black icon is from Breeze Icons and not from Okular.

> This could be more easily implemented by adding [etc.]

Can you add feedback to the below merge request? That would be appreciated, although that merge request is a bit stale.

https://invent.kde.org/graphics/okular/-/merge_requests/141

Comment 2 Nate Graham 2021-05-28 19:46:18 UTC

David, aren't you working on basically exactly this?

Comment 3 Laura David Hurka 2021-05-28 20:24:28 UTC

Yes, that is the merge request. But I need to continue my almost finished work. ;)

Comment 4 Victor 2021-05-28 21:27:48 UTC

> Which icon? The Okular application icon? Anyway, that is a different issue,
> the black icon is from Breeze Icons and not from Okular.

I will create another bug report later!

> 
> Can you add feedback to the below merge request? 

I made a review there. I couldn't understand the technical discussions, but from a viewpoint of a regular user I hope what I said helps.

Thanks guys!

Comment 5 Laura David Hurka 2021-05-29 23:09:09 UTC

Git commit 195bbe3636155613555c27f4e67d21aa1461a5b6 by David Hurka.
Committed on 29/05/2021 at 23:08.
Pushed by davidhurka into branch 'master'.

Create color mode menu.

Implemented using a ColorModeMenu class,
derived from ToggleActionMenu (derived from KActionMenu),
as a child object of PageView.

* KToggleAction for every color mode, allows to set shortcuts for every mode.
  Color mode actions have icons.
* KToggleAction for normal colors mode.
* ToggleActionMenu containing all color mode actions.
  If triggered, toggles color mode between normal colors and last change colors mode.

"Toggle Change Colors" is replaced by "Change Colors", which is actually a toggle action.
Related: bug 407217

M  +2    -1    CMakeLists.txt
M  +7    -0    conf/okular.kcfg
M  +4    -0    conf/okular_core.kcfg
A  +145  -0    part/colormodemenu.cpp     [License: GPL (v2+)]
A  +74   -0    part/colormodemenu.h     [License: GPL (v2+)]
M  +7    -15   part/pageview.cpp
M  +0    -3    part/pageview.h
M  +19   -2    part/part.cpp
M  +1    -0    part/part.h
M  +8    -1    part/preferencesdialog.cpp
M  +2    -0    part/preferencesdialog.h

https://invent.kde.org/graphics/okular/commit/195bbe3636155613555c27f4e67d21aa1461a5b6