Summary: | Shortcut with Ampersand not correctly shown | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kdeclarative | Reporter: | Colour Delete <colourdelete> |
Component: | general | Assignee: | Marco Martin <notmart> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, kdelibs-bugs, nate |
Priority: | NOR | ||
Version: | 5.82.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/kdeclarative/commit/ca86b73f754947b1a2c1a0223c81634480c3a3f1 | Version Fixed In: | 5.83 |
Description
Colour Delete
2021-05-26 22:13:59 UTC
Yeah, looks like it's not correctly escaped. Hi, I was just wondering, since I think the keyboard shortcut widget is used in many places, the fix would be on the widget, not the System Settings app? Thanks, Ken A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kdeclarative/-/merge_requests/61 (In reply to Colour Delete from comment #2) > Hi, > > I was just wondering, since I think the keyboard shortcut widget is used in > many places, the fix would be on the widget, not the System Settings app? > > Thanks, > Ken Yup. :) Understood; thank you! Git commit ca86b73f754947b1a2c1a0223c81634480c3a3f1 by Nate Graham. Committed on 27/05/2021 at 22:59. Pushed by ngraham into branch 'master'. [KeySequenceItem] Display ampersands in shortcuts We have to replace the single ampersand that we get back from QKeySequence::toString() to be two ampersands, because the QQC2 Button that will display this string interprets a single ampersand as a mnemonic and hides it, which is not correct for our use of it here. FIXED-IN: 5.83 M +6 -1 src/qmlcontrols/kquickcontrols/KeySequenceItem.qml https://invent.kde.org/frameworks/kdeclarative/commit/ca86b73f754947b1a2c1a0223c81634480c3a3f1 |