Bug 437605

Summary:	Tooltips of some buttons in Entries section of system tray settings have unnecessary "&" character
Product:	[Plasma] plasmashell	Reporter:	Patrick Silva <bugseforuns>
Component:	System Tray widget	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	materka, nate, nicolas.fella
Priority:	NOR
Version First Reported In:	master
Target Milestone:	1.0
Platform:	Neon
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-workspace/commit/ef23b8f89aea50309a45ee38275cdd9a0660830b	Version Fixed/Implemented In:	5.22
Sentry Crash Report:
Attachments:	screenshot

Description Patrick Silva 2021-05-24 12:56:52 UTC

STEPS TO REPRODUCE
1. open system tray settings
2. click on "Entries" in the left side
3. hover over the rightmost buttons of the following rows:
Notifications
Battery and Brightness
Bluetooth
Printers

OBSERVED RESULT
tooltips of hovered buttons include a unnecessary "&" character.
I'm attaching a screenshot showing the case of Battery and Brightness row.

EXPECTED RESULT
tooltips should not have unnecessary "&" character

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.22.80
KDE Frameworks Version: 5.83.0
Qt Version: 5.15.2
Graphics Platform: Wayland

Comment 1 Patrick Silva 2021-05-24 12:57:12 UTC

Created attachment 138739 [details]
screenshot

Comment 2 Nicolas Fella 2021-05-24 13:44:15 UTC

This seems to affect all applets that set a custom configure action

Comment 3 Nicolas Fella 2021-05-24 13:48:38 UTC

The cause is obvious, the & is part of the action name: https://invent.kde.org/plasma/plasma-workspace/-/blob/master/applets/notifications/package/contents/ui/main.qml#L191

How to fix it properly isn't though

Comment 4 Bug Janitor Service 2021-05-24 14:05:06 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/882

Comment 5 Nate Graham 2021-05-24 19:47:32 UTC

Git commit 9a0f7f24306794b93ef0e3e10c848ff5db3e882c by Nate Graham, on behalf of Nicolas Fella.
Committed on 24/05/2021 at 19:47.
Pushed by ngraham into branch 'master'.

[applets/systemtray] Strip mnemonic ampersand from entry config tooltip

Some applet config titles contain ampersands for mnemonic purposes. PC3.ToolTip filters them out but QQC2.Tooltip does not, so they are visible in the system tray config window.

M  +3    -1    applets/systemtray/package/contents/ui/ConfigEntries.qml

https://invent.kde.org/plasma/plasma-workspace/commit/9a0f7f24306794b93ef0e3e10c848ff5db3e882c

Comment 6 Nate Graham 2021-05-24 19:48:24 UTC

Git commit ef23b8f89aea50309a45ee38275cdd9a0660830b by Nate Graham, on behalf of Nicolas Fella.
Committed on 24/05/2021 at 19:48.
Pushed by ngraham into branch 'Plasma/5.22'.

[applets/systemtray] Strip mnemonic ampersand from entry config tooltip

Some applet config titles contain ampersands for mnemonic purposes. PC3.ToolTip filters them out but QQC2.Tooltip does not, so they are visible in the system tray config window.


(cherry picked from commit 9a0f7f24306794b93ef0e3e10c848ff5db3e882c)

M  +3    -1    applets/systemtray/package/contents/ui/ConfigEntries.qml

https://invent.kde.org/plasma/plasma-workspace/commit/ef23b8f89aea50309a45ee38275cdd9a0660830b