| Summary: | default network should be switched to irc.libera.chat | ||
|---|---|---|---|
| Product: | [Applications] konversation | Reporter: | Rik Mills <rikmills> |
| Component: | general | Assignee: | Konversation Developers <konversation-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | christian.l.christiansen, luigi.toscano |
| Priority: | NOR | ||
| Version: | Git | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/network/konversation/commit/e6c7acff061ea93e137f3e367c403b4953036499 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Rik Mills
2021-05-24 06:13:20 UTC
Git commit a7628bc668ba36f36458159682025c601538fa57 by Christian Christiansen. Committed on 25/05/2021 at 08:47. Pushed by cchristiansen into branch 'master'. Replace Freenode with Libera KDE has moved to Libera.Chat. Make Libera.Chat the default network. Update the documentation to reflect this move too. M +1 -1 README M +31 -31 data/org.kde.konversation.appdata.xml M +4 -4 doc/index.docbook M +1 -1 src/application.h M +2 -2 src/config/preferences.cpp M +1 -1 src/irc/servergroupdialogui.ui M +1 -1 src/irc/serverlistdialogui.ui https://invent.kde.org/network/konversation/commit/a7628bc668ba36f36458159682025c601538fa57 KDE hasn't moved *yet*. Some of the changes could have been merged, but I commented on the change as some of them I believe could have been better. Next time please send a merge request. Sorry for the premature commit. Should I undo the last commit until KDE officially moves? Fuchs says Libera network is fine. With regards to the merge request, I apologise. I haven't committed since the migration to GitLab and became confused. Is there specific documentation on how to create a merge request? I'll ensure it goes through the proper process next time. You are still free to commit directly, of course. When a change may require some input though it may be better to send a review request for other people to comment. Also, in the future (but not now) when we fully move to the gitlab CI we will have pre-commit jobs running on each review, which will be useful even for your own commit to ensure they don't break anything obvious. For more information about merge requests please check https://community.kde.org/Infrastructure/GitLab#Submitting_a_merge_request Given the comments on the change, my suggestion about it is: - keep the reference in the documentation and examples whenever it is about a "some network" - revert the reference to the official channel for now, which may mean also changing the default network (and if you want, keep a review request ready to be merged when it's the right time), and probably reopen this bug - if you agree, rework the appdata file to not reference a specific network (I guess debian users mostly use konversation on oftc, for example). Git commit 117499917c49b3bdd280d35295be57946fcf98ee by Luigi Toscano. Committed on 27/06/2021 at 20:33. Pushed by ltoscano into branch 'master'. appdata: reference Libera, fix the wording The description seemed to imply basically all distributions are on a specific network, which is not the case. M +3 -3 data/org.kde.konversation.appdata.xml https://invent.kde.org/network/konversation/commit/117499917c49b3bdd280d35295be57946fcf98ee Git commit e6c7acff061ea93e137f3e367c403b4953036499 by Luigi Toscano, on behalf of Christian Christiansen. Committed on 27/06/2021 at 20:33. Pushed by ltoscano into branch 'master'. Replace Freenode with Libera KDE has moved to Libera.Chat. Make Libera.Chat the default network. Update the documentation to reflect this move too. M +4 -4 doc/index.docbook M +1 -1 src/application.h M +1 -1 src/irc/servergroupdialogui.ui M +1 -1 src/irc/serverlistdialogui.ui https://invent.kde.org/network/konversation/commit/e6c7acff061ea93e137f3e367c403b4953036499 Git commit fd7f8a87a703647cb9cb8d4089691ab7b0efc9f4 by Luigi Toscano. Committed on 27/06/2021 at 20:16. Pushed by ltoscano into branch 'master'. Minimal changes to use libera.chat Change the reference to libera in non-translatable strings first, so that this patch can be easily cherry-picked and backported. M +1 -1 README M +2 -2 src/config/preferences.cpp https://invent.kde.org/network/konversation/commit/fd7f8a87a703647cb9cb8d4089691ab7b0efc9f4 Git commit 8ccc5223aeaccfa9d22b7e055c87ea652f17ba0b by Luigi Toscano. Committed on 27/06/2021 at 20:49. Pushed by ltoscano into branch 'release/21.04'. Minimal changes to use libera.chat Change the reference to libera in non-translatable strings first, so that this patch can be easily cherry-picked and backported. (cherry picked from commit fd7f8a87a703647cb9cb8d4089691ab7b0efc9f4) M +1 -1 README M +2 -2 src/config/preferences.cpp https://invent.kde.org/network/konversation/commit/8ccc5223aeaccfa9d22b7e055c87ea652f17ba0b |