Bug 437574

Summary:	Can't save k3b project or exit the application
Product:	[Applications] k3b	Reporter:	Tom Collins <ltskinol>
Component:	GUI/Usability	Assignee:	k3b developers <k3b>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aacid, bugseforuns, id012c3076, michalm, trueg
Priority:	NOR
Version:	21.04.1
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://invent.kde.org/multimedia/k3b/commit/2a4b66e3a417559599d3bc61ce6497e17ec98472	Version Fixed In:
Sentry Crash Report:
Attachments:	Screenshot

Description Tom Collins 2021-05-23 20:22:04 UTC

SUMMARY
Can't re-save k3b project file.

STEPS TO REPRODUCE
1. Start k3b.
2. File->New Project->New Audio CD Project
3. Drop a file into the project.
4. File->Save as...
5. Save as /tmp/abc.  The file dialog will add the .k3b extension.
6. Having made no further changes, press Ctl+S to save again.

OBSERVED RESULT
k3b pops up the "File Already Exists" dialog, which looks normal, bur somehow doesn't have the focus.  You can't change the file name, or click on any of the buttons.  No combination of tab, typing or clicking the mouse can use or dismiss this dialog box, and you have to forcibly kill k3b (thus losing any changes you made) to get out.

EXPECTED RESULT
k3b saves the file w/o prompting or hanging.


SOFTWARE/OS VERSIONS
KDE Frameworks Version: KDE Frameworks 5.82.0
Qt Version: Qt 5.15.2 (built against 5.15.2)

Related to, but different than, bug 392617.

Comment 1 Tom Collins 2021-05-23 20:27:09 UTC

Forgot to add - a k3b :Progress Dialog" also pops up - similarly unresponsive to mouse clicks.  Screenshot attached.

Comment 2 Tom Collins 2021-05-23 20:30:04 UTC

Created attachment 138716 [details]
Screenshot

Comment 3 Bug Janitor Service 2021-05-24 09:58:36 UTC

A possibly relevant merge request was started @ https://invent.kde.org/multimedia/k3b/-/merge_requests/10

Comment 4 Patrick Silva 2021-05-30 14:14:43 UTC

possibly bug 392617 is a duplicate.

Comment 5 Tom Collins 2021-05-30 16:09:59 UTC

Patrick - I mentioned that one in the original bug submission.  I think they're related, but not the same bug.

Comment 6 Albert Astals Cid 2021-06-04 21:16:46 UTC

Git commit 2a4b66e3a417559599d3bc61ce6497e17ec98472 by Albert Astals Cid.
Committed on 24/05/2021 at 09:57.
Pushed by aacid into branch 'release/21.04'.

Fix showing of dialog the user can't interact with when saving

The issue is using KIO::move + exec() can show a dialog but exec says
to QEventLoop::ExcludeUserInputEvents so the user is stuck there
forever.

Move to KIO::file_move since we're moving files anyway and set overwrite
since we're already asking if the file exists anyway (twice in fact, fix
coming in the next commit)

M  +2    -2    src/k3bprojectmanager.cpp

https://invent.kde.org/multimedia/k3b/commit/2a4b66e3a417559599d3bc61ce6497e17ec98472

Comment 7 Patrick Silva 2021-06-05 00:04:23 UTC

I can't reproduce my bug after this fix.
Thank you Albert.

Comment 8 Patrick Silva 2021-06-05 00:04:33 UTC

*** Bug 392617 has been marked as a duplicate of this bug. ***

Comment 9 Tom Collins 2021-06-05 02:06:30 UTC

Thank you for the fix!

Comment 10 Patrick Silva 2021-11-01 02:17:49 UTC

*** Bug 444729 has been marked as a duplicate of this bug. ***