Bug 437549

Summary:	Icons too big on vertical panel
Product:	[Plasma] plasmashell	Reporter:	Matthias Mueller <mat.mueller>
Component:	System Tray	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	materka, nate, notmart
Priority:	NOR
Version:	5.21.5
Target Milestone:	1.0
Platform:	Manjaro
OS:	Linux
Latest Commit:		Version Fixed In:	5.22
Sentry Crash Report:
Attachments:	Panel with "fit to width" and "small icons" in comparison Comparison vertical/horizontal panel

Description Matthias Mueller 2021-05-23 14:36:09 UTC

Created attachment 138706 [details]
Panel with "fit to width" and "small icons" in comparison

For a while now (i think since 5.21?), the icons in the system tray applet are way too big on a vertical panel, if option "fit to width" is used (and much too small if "small icons" is used ;) ). It's like the icon-size is calculated without any padding (well seen at the anydesk or element-icons in my screenshot)
I initially thought this was related to https://bugs.kde.org/show_bug.cgi?id=433138 , but that assumption was wrong it seems.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.21.5
KDE Frameworks Version: 5.82.0
Qt Version: 5.15.2

Comment 1 Matthias Mueller 2021-05-23 14:37:51 UTC

Created attachment 138707 [details]
Comparison vertical/horizontal panel

Both panels have "fit to width"/"fit to height" active and a panel height of 50

Comment 2 Marco Martin 2021-05-24 15:03:48 UTC

The actual problem is small icons being too small, most likely high dpi scaling not being perfect?

fit to width is doing exactly what is supposed to do, to make systary icons as big as icons putside, like the start menu

Comment 3 Marco Martin 2021-05-24 15:08:44 UTC

also, is the "margins separator" applet right before the systemtray?

that's the element the panel uses to make the systray and the clock applets a bit smaller than the rest

can you post a screenshot of that vertical panel in edit mode?

Comment 4 Matthias Mueller 2021-05-24 15:55:05 UTC

If fit to width would be working correctly, then fit to height wouldn't. and as the icons are way bigger than anything else (see task manager for example), i think my first explanation makes more sense ^^

And i specifically removed the margin separator on the horizontal default-panel to show the same state (as margin separator doesn't work on vertical panels, but that's an other bug i guess).

What exactly would you want to see in edit mode? I just tried to take a screenshot and noticed it looks exactly as without editing (i guess you want to make sure no  margin separator is present?)

Comment 5 Nate Graham 2021-05-26 18:25:52 UTC

It's sadly a known bug that margins in vertical panels aren't respected. We couldn't fix it in the 5.21 release because it relied on SVG changes that were in a newer frameworks version.It's fixed in Plasma 5.22 already.

Comment 6 Matthias Mueller 2021-05-26 19:16:34 UTC

A known and fixed bug is the best bug! Thanks for the heads up :)