| Summary: | Notification says "Moving" while Dolphin undoes mass renaming | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Patrick Silva <bugseforuns> |
| Component: | general | Assignee: | KIO Bugs <kio-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kdelibs-bugs, nate |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=391592 | ||
| Latest Commit: | https://invent.kde.org/frameworks/kio/commit/0bf55cca04fd59f6dffd334d22a950d7209213f7 | Version Fixed In: | 5.97 |
| Attachments: | screenshot | ||
Yeah technically renaming is a move operation, but the UI should display more accurate text here. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/909 Git commit 0bf55cca04fd59f6dffd334d22a950d7209213f7 by Ahmad Samir. Committed on 25/07/2022 at 12:34. Pushed by ahmadsamir into branch 'master'. FileUndoManager: fix job description when undoing a batch-renaming It should be "Renaming", not "Moving". FIXED-IN: 5.97 M +28 -5 src/widgets/fileundomanager.cpp https://invent.kde.org/frameworks/kio/commit/0bf55cca04fd59f6dffd334d22a950d7209213f7 Not completely fixed. The notification is still saying 'Moving' when I undo mass renaming by pressing ctrl+z. Now is completely fixed on neon unstable. :) Bug 391592 is related to this one. |
Created attachment 138685 [details] screenshot SUMMARY While Dolphin undoes mass renaming (2140 jpg files in my case), Plasma displays a notification with a ping-pong "progress" bar saying "Moving". When the operation is completed, another notification says "Moving (Finished)". Please see the attached screenshot. Saying "Moving" when the user did not move anything does not sound correct, it is confusing instead. STEPS TO REPRODUCE 1. open a folder containing thousands of files 2. select all files by pressing ctrl+a 3. press F2 4. type another file name and press enter/return 5. undo mass renaming by pressing ctrl+z EXPECTED RESULT do not say "moving" when the user does not move anything SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.22.80 KDE Frameworks Version: 5.83.0 Qt Version: 5.15.2 Kernel Version: 5.8.0-53-generic (64-bit) Graphics Platform: Wayland