Bug 437377

Summary: Leaving annotation mode with mouse is complicated
Product: [Applications] okular Reporter: Frederik Schwarzer <schwarzer>
Component: generalAssignee: Okular developers <okular-devel>
Status: RESOLVED FIXED    
Severity: normal CC: nate, simgunz
Priority: NOR Keywords: usability
Version First Reported In: 21.04.1   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://invent.kde.org/graphics/okular/commit/230a68d537a2f958f72dce162221555ef285896f Version Fixed/Implemented In: 21.08
Sentry Crash Report:

Description Frederik Schwarzer 2021-05-19 21:24:05 UTC 
SUMMARY
When I enter annotation mode by clicking the toolbar button, I cannot switch back to browse mode with the mouse easily

STEPS TO REPRODUCE
1. Select Browse mode from tool bar
2. Select Quick Annotation from tool bar and select e.g. "Note"
Now Okular is in Annotation mode but in the tool bar the Browse mode is selected

3. click on Browse mode in tool bar
Nothing happens

4. click on Text Selection mode in tool bar
Now Okular is in Text Selection mode

5. click on Browse mode again
Okular is now back in Browse mode


EXPECTED RESULT
When in Annotation mode, the annotation mode button should be selected so that clicking the Browse mode button gets you back to browse mode.

SOFTWARE/OS VERSIONS
KDE Frameworks 5.82.0
Qt 5.15.2
Comment 1 Nate Graham 2021-05-20 17:16:09 UTC 
Yes, these should be mutually exclusive actions IMO. Only one selected at a time.
Comment 2 Simone Gaiarin 2021-05-20 19:49:55 UTC 
I'll try to fix this soon
Comment 3 Bug Janitor Service 2021-06-05 17:47:16 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/439
Comment 4 Albert Astals Cid 2021-06-19 15:59:43 UTC 
Git commit 230a68d537a2f958f72dce162221555ef285896f by Albert Astals Cid, on behalf of Simone Gaiarin.
Committed on 19/06/2021 at 14:12.
Pushed by aacid into branch 'master'.

Uncheck mouse mode action when annotation tool selected

When the annotation is unchecked the previous mouse mode is restored.

The slot slotMouseNormalToggled is changed back to its original version
of slotSetMouseNormal given that we needed to pass the checked state
only to detach the annotations, and we do it in the lambda now.
Related: bug 398108

FIXED-IN: 21.08

M  +11   -5    autotests/annotationtoolbartest.cpp
M  +45   -15   part/pageview.cpp
M  +1    -1    part/pageview.h
M  +2    -2    part/pageviewannotator.cpp
M  +4    -1    part/pageviewannotator.h

https://invent.kde.org/graphics/okular/commit/230a68d537a2f958f72dce162221555ef285896f