Bug 437292

Summary: Discover "author" can confuses publisher and developer depending on the backend; consider separating displaying them separately
Product: [Applications] Discover Reporter: francisco_t <leviatan1>
Component: discoverAssignee: Dan Leinir Turthra Jensen <leinir>
Status: RESOLVED UPSTREAM    
Severity: normal CC: aleixpol, nate
Priority: NOR Keywords: usability
Version First Reported In: 5.21.5   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Flatpak info from discover about keepassxc
snap info from discover about keepassxc

Description francisco_t 2021-05-18 07:45:27 UTC
Created attachment 138528 [details]
Flatpak info from discover about keepassxc

STEPS TO REPRODUCE
1. I want to install keepassxc from discover but "author" confuses me.

2. One of the package from developer is Snap: https://keepassxc.org/download/#linux

3. I see the "Author" in discover's flatpak is "Keepassxc developer" but It's not a package from developers: https://github.com/keepassxreboot/keepassxc/issues/1524


EXPECTED RESULT
I want the official package. I know snap is not verificated package from Canonical, BUT the flatpak is not from developer!


ADDITIONAL INFORMATION
Operating System: KDE neon 5.21
KDE Plasma Version: 5.21.5
KDE Frameworks Version: 5.82.0
Qt Version: 5.15.2
Kernel Version: 5.8.0-53-generic
OS Type: 64-bit
Comment 1 francisco_t 2021-05-18 07:45:58 UTC
Created attachment 138529 [details]
snap info from discover about keepassxc
Comment 2 Nate Graham 2021-05-18 21:51:42 UTC
This information comes entirely from the packages' metadata; Discover is simply consuming that information and passing it onto you. We don't have a way to verify if the stated author is accurate or not. The people supposed to be doing this are the packagers of your distro/Snap/FlatHub/wherever you're getting your apps from If any of this information if incorrect, you would need to contact the packagers and tell them about it.
Comment 3 francisco_t 2021-05-19 09:42:04 UTC
(In reply to Nate Graham from comment #2)
> This information comes entirely from the packages' metadata; Discover is
> simply consuming that information and passing it onto you. We don't have a
> way to verify if the stated author is accurate or not. The people supposed
> to be doing this are the packagers of your distro/Snap/FlatHub/wherever
> you're getting your apps from If any of this information if incorrect, you
> would need to contact the packagers and tell them about it.

You are right. But the data from snap or flatpak are different to "Author". 

Example snap:
https://snapcraft.io/keepassxc
Info from snap site: Website and contact
Discover show me Author: Contact
I think the name of "author" is wrong. The data is "contact"

Example Flatpak:
https://flathub.org/apps/details/org.keepassxc.KeePassXC
Info from flatpak site: Developer and publisher
Developer: keepass team
Publisher: see detail (some guys from flathub)
I think "Author" is wrong again. The data from flatpak is who is the devs.

I think flatpak and snap information is a big disaster but Discover doesn't help with the "Author" tag.

Does the "author" word come from flatpak/snap?

I think the name "Author" is confusing and wrong anyway.

Sorry, but it's difficult explain the problem.
Comment 4 Nate Graham 2021-05-19 16:17:06 UTC
Ah, I understand your complaint now.

However is there really a significant difference between "Developer" and "Author"? I suppose we could change the word to "Developer" but that feels like a less friendly more technical term. Can you explain maybe in more detail what you don't like about the word "Author"?
Comment 5 francisco_t 2021-05-19 17:51:12 UTC
(In reply to Nate Graham from comment #4)
> Ah, I understand your complaint now.
> 
> However is there really a significant difference between "Developer" and
> "Author"? I suppose we could change the word to "Developer" but that feels
> like a less friendly more technical term. Can you explain maybe in more
> detail what you don't like about the word "Author"?

I like the word "author"

It's confuse because:
- Snap "author" is the publisher (checked to certificate, good point)
- Flatpak "author" is the developer (and looks like certificated but who knows)

 I think a good solution would be that discover shows the author (developer) and the publisher separately, specially in flatpak.


P.S. Look firefox in snap and flatpak. Both official packages from mozilla:
https://flathub.org/apps/details/org.mozilla.firefox
https://snapcraft.io/firefox
but flatpak in discover has not author (?!)
Comment 6 Nate Graham 2021-05-20 15:01:08 UTC
Yeah, that seems sensible enough.
Comment 7 Aleix Pol 2021-05-24 01:14:19 UTC
https://github.com/keepassxreboot/keepassxc/blob/2423bede60914740854ceb37034464ff4ff09f89/share/linux/org.keepassxc.KeePassXC.appdata.xml#L12

We can't do magic there. This needs addressing in their own metadata.
Comment 8 Aleix Pol 2021-05-24 01:43:55 UTC
Here's Firefox's appstream metadata. They do not specify a developer or an author at all.

<component type="desktop">
    <id>org.mozilla.firefox</id>
    <name>Firefox</name>
    <summary>Mozilla Firefox Web Browser</summary>
    <description><p>The Firefox standalone app for Linux is here</p><p>Get uncompromised access to the web by blending integrated privacy features and extensions with incredible performance.</p><p>Features:</p><ul><li>A powerful engine that’s built for rapidfire performance no matter how many tabs you’re switching between</li><li>Automatic privacy protection to safeguard your personal data against 2000+ online trackers</li><li>Faster page loading by blocking disruptive ads and scripts that hijack your browsing experience</li></ul><p>One account to sync them all</p><p>Seamlessly access passwords, bookmarks and more from all your devices. Plus, use the Send Tabs feature to instantly share open tabs between desktop, mobile and tablet.</p><p>Browse for good</p><p>We never track, collect or store your personal data. The Firefox Browser is made by Mozilla, the non-profit champions of a healthy internet. Mozilla also tackles issues like privacy, misinformation and trolling by investing in fellowships, campaigns and new technologies designed to make the internet a healthier place that’s open to everyone.</p></description>
    <icon type="cached" height="64" width="64">org.mozilla.firefox.png</icon>
    <icon type="cached" height="128" width="128">org.mozilla.firefox.png</icon>
    <categories>
      <category>Network</category>
      <category>WebBrowser</category>
    </categories>
    <keywords>
      <keyword>browser</keyword>
      <keyword>internet</keyword>
      <keyword>mozilla</keyword>
      <keyword>web</keyword>
    </keywords>
    <kudos>
      <kudo>HiDpiIcon</kudo>
    </kudos>
    <mimetypes>
      <mimetype>application/vnd.mozilla.xul+xml</mimetype>
      <mimetype>application/xhtml+xml</mimetype>
      <mimetype>text/html</mimetype>
      <mimetype>text/mml</mimetype>
      <mimetype>text/xml</mimetype>
      <mimetype>x-scheme-handler/http</mimetype>
      <mimetype>x-scheme-handler/https</mimetype>
    </mimetypes>
    <project_license>MPL-2.0</project_license>
    <url type="bugtracker">https://bugzilla.mozilla.org/</url>
    <url type="donation">https://donate.mozilla.org/</url>
    <url type="help">https://support.mozilla.org/</url>
    <url type="homepage">https://www.mozilla.org/firefox/</url>
    <url type="translate">https://wiki.mozilla.org/L10n:Starting_a_localization</url>
    <screenshots>
      <screenshot type="default">
        <image type="source">https://raw.githubusercontent.com/mozilla-releng/scriptworker-scripts/master/pushflatpakscript/media/screenshots/image1.png</image>
        <image type="thumbnail" height="351" width="624">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/624x351/org.mozilla.firefox-86a0aafdff81b0f40fb0424c12e05227.png</image>
        <image type="thumbnail" height="702" width="1248">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/1248x702/org.mozilla.firefox-86a0aafdff81b0f40fb0424c12e05227.png</image>
        <image type="thumbnail" height="63" width="112">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/112x63/org.mozilla.firefox-86a0aafdff81b0f40fb0424c12e05227.png</image>
        <image type="thumbnail" height="126" width="224">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/224x126/org.mozilla.firefox-86a0aafdff81b0f40fb0424c12e05227.png</image>
        <image type="thumbnail" height="423" width="752">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/752x423/org.mozilla.firefox-86a0aafdff81b0f40fb0424c12e05227.png</image>
        <image type="thumbnail" height="846" width="1504">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/1504x846/org.mozilla.firefox-86a0aafdff81b0f40fb0424c12e05227.png</image>
      </screenshot>
      <screenshot>
        <image type="source">https://raw.githubusercontent.com/mozilla-releng/scriptworker-scripts/master/pushflatpakscript/media/screenshots/image2.png</image>
        <image type="thumbnail" height="351" width="624">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/624x351/org.mozilla.firefox-4ca64b27e45f80eed6938222db51d447.png</image>
        <image type="thumbnail" height="702" width="1248">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/1248x702/org.mozilla.firefox-4ca64b27e45f80eed6938222db51d447.png</image>
        <image type="thumbnail" height="63" width="112">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/112x63/org.mozilla.firefox-4ca64b27e45f80eed6938222db51d447.png</image>
        <image type="thumbnail" height="126" width="224">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/224x126/org.mozilla.firefox-4ca64b27e45f80eed6938222db51d447.png</image>
        <image type="thumbnail" height="423" width="752">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/752x423/org.mozilla.firefox-4ca64b27e45f80eed6938222db51d447.png</image>
        <image type="thumbnail" height="846" width="1504">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/1504x846/org.mozilla.firefox-4ca64b27e45f80eed6938222db51d447.png</image>
      </screenshot>
      <screenshot>
        <image type="source">https://raw.githubusercontent.com/mozilla-releng/scriptworker-scripts/master/pushflatpakscript/media/screenshots/image3.png</image>
        <image type="thumbnail" height="351" width="624">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/624x351/org.mozilla.firefox-5a8d73503cf087a727a712276f3e68b5.png</image>
        <image type="thumbnail" height="702" width="1248">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/1248x702/org.mozilla.firefox-5a8d73503cf087a727a712276f3e68b5.png</image>
        <image type="thumbnail" height="63" width="112">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/112x63/org.mozilla.firefox-5a8d73503cf087a727a712276f3e68b5.png</image>
        <image type="thumbnail" height="126" width="224">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/224x126/org.mozilla.firefox-5a8d73503cf087a727a712276f3e68b5.png</image>
        <image type="thumbnail" height="423" width="752">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/752x423/org.mozilla.firefox-5a8d73503cf087a727a712276f3e68b5.png</image>
        <image type="thumbnail" height="846" width="1504">https://dl.flathub.org/repo/screenshots/org.mozilla.firefox-stable/1504x846/org.mozilla.firefox-5a8d73503cf087a727a712276f3e68b5.png</image>
      </screenshot>
    </screenshots>
    <content_rating type="oars-1.1"/>
    <releases>
      <release timestamp="1620086400" version="88.0.1"/>
    </releases>
    <launchable type="desktop-id">org.mozilla.firefox.desktop</launchable>
    <bundle type="flatpak" runtime="org.freedesktop.Platform/x86_64/20.08" sdk="org.freedesktop.Sdk/x86_64/20.08">app/org.mozilla.firefox/x86_64/stable</bundle>
  </component><component type="desktop">
    <id>org.mpdevil.mpdevil</id>
    <name>mpdevil</name>
    <summary>A simple music browser for MPD</summary>
    <description><p>Mpdevil is a simple music browser for the Music Player Daemon (MPD) which is focused on playing local music without the need of managing playlists. Instead of maintaining a client side database of your music library mpdevil loads all tags and covers on demand. So you&apos;ll never see any outdated information in the browser. Mpdevil strongly relies on tags.</p><ul><li>display large covers</li><li>play songs without doubleclick</li><li>fetch lyrics</li><li>MPRIS interface</li><li>notifications on title change</li><li>basic queue manipulation (move and delete single tracks)</li><li>search songs</li><li>filter by genre</li><li>media keys support</li><li>many shortcuts</li><li>manage multiple mpd servers</li></ul></description>
    <icon type="cached" height="64" width="64">org.mpdevil.mpdevil.png</icon>
    <icon type="cached" height="128" width="128">org.mpdevil.mpdevil.png</icon>
    <categories>
      <category>Audio</category>
      <category>AudioVideo</category>
      <category>Player</category>
    </categories>
    <kudos>
      <kudo>HiDpiIcon</kudo>
    </kudos>
    <project_license>GPL-3.0</project_license>
    <url type="bugtracker">https://github.com/SoongNoonien/mpdevil/issues</url>
    <url type="homepage">https://github.com/SoongNoonien/mpdevil</url>
    <screenshots>
      <screenshot type="default">
        <image type="source">https://raw.githubusercontent.com/SoongNoonien/mpdevil/v1.1.0/screenshots/mainwindow_1.1.0.png</image>
        <image type="thumbnail" height="351" width="624">https://dl.flathub.org/repo/screenshots/org.mpdevil.mpdevil-stable/624x351/org.mpdevil.mpdevil-42cf9ee576ed41b85a1fe0f6a24cc5e2.png</image>
        <image type="thumbnail" height="63" width="112">https://dl.flathub.org/repo/screenshots/org.mpdevil.mpdevil-stable/112x63/org.mpdevil.mpdevil-42cf9ee576ed41b85a1fe0f6a24cc5e2.png</image>
        <image type="thumbnail" height="126" width="224">https://dl.flathub.org/repo/screenshots/org.mpdevil.mpdevil-stable/224x126/org.mpdevil.mpdevil-42cf9ee576ed41b85a1fe0f6a24cc5e2.png</image>
        <image type="thumbnail" height="423" width="752">https://dl.flathub.org/repo/screenshots/org.mpdevil.mpdevil-stable/752x423/org.mpdevil.mpdevil-42cf9ee576ed41b85a1fe0f6a24cc5e2.png</image>
      </screenshot>
    </screenshots>
    <content_rating type="oars-1.1"/>
    <releases>
      <release timestamp="1620086400" version="1.2.1"/>
    </releases>
    <provides>
      <binary>mpdevil</binary>
    </provides>
    <launchable type="desktop-id">org.mpdevil.mpdevil.desktop</launchable>
    <bundle type="flatpak" runtime="org.gnome.Platform/x86_64/3.38" sdk="org.gnome.Sdk/x86_64/3.38">app/org.mpdevil.mpdevil/x86_64/stable</bundle>
  </component>