Bug 437260

Summary:	Minor discrepancy in scripts
Product:	[Applications] digikam	Reporter:	Loic <loickerneth>
Component:	Bundle-AppImage	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	caulier.gilles
Priority:	NOR
Version First Reported In:	7.5.0
Target Milestone:	---
Platform:	Mageia RPMs
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:	7.5.0
Sentry Crash Report:

Description Loic 2021-05-17 15:17:37 UTC

SUMMARY

I would like to report a minor discrepancy in the scripts used to build appimage bundles. Specifically, in script 04-build-appimage.sh, there is a line copying some opencv  files : 
« cp -r /usr/share/OpenCV   ./usr/share »

The OpenCV folder is brought by the installation of ffmpeg-devel in script 01-build-host.sh, because in Mageia7, ffmpeg version 4.1.x depends on and enables opencv (which is no longer the case in Mageia8). Now, the 01-build-host.sh script also builds opencv 4.5.1 and installs its files in /usr/share/opencv4.

So the question is : should the  04-build-appimage.sh script move the OpenCV or the opencv4 folder into /usr/share ? Or does it make no difference ?

Also, please consider updating digikam git url in both README and config.sh files.

Comment 1 caulier.gilles 2021-12-13 08:06:09 UTC

Git commit 79b12fd45812da88a521afb5f62dfdaad1758928 by Gilles Caulier.
Committed on 13/12/2021 at 07:46.
Pushed by cgilles into branch 'master'.

fix git url

M  +1    -1    project/bundles/appimage/README

https://invent.kde.org/graphics/digikam/commit/79b12fd45812da88a521afb5f62dfdaad1758928

Comment 2 caulier.gilles 2021-12-13 08:08:30 UTC

About opencv files, see my comment here :

https://invent.kde.org/graphics/digikam/-/blob/master/project/bundles/appimage/04-build-appimage.sh#L132

Gilles Caulier