Bug 437242

Summary:	Close modified document dialog doesn't make logical sense
Product:	[Applications] kate	Reporter:	Steve Kerr <steve>
Component:	application	Assignee:	KWrite Developers <kwrite-bugs-null>
Status:	RESOLVED NOT A BUG
Severity:	normal	CC:	jpmbatrina01
Priority:	NOR
Version First Reported In:	19.12.3
Target Milestone:	---
Platform:	Other
OS:	Other
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Kate close dialog Breeze theme

Description Steve Kerr 2021-05-17 10:52:56 UTC

SUMMARY
The "Close Document" dialog asks "Do you want to save your changes or discard them?". The buttons are labelled Yes, No and Cancel. None of these options answers the question. 

STEPS TO REPRODUCE
1. Open Kate and add some text to an empty file but do not save the file
2. Attempt close the file by any normal means

OBSERVED RESULT
The Close Document dialog indicates the document has been modified and asks "Do you want to save your change or discard them?". The selection buttons are labelled Yes, No and Cancel. 

EXPECTED RESULT
Either:
   1) The dialog should ask "Do you want to save your changes?"
or:
   2) The buttons should be labelled Save, Discard, Cancel.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kubuntu 20.04
KDE Plasma Version: 5.18.5
KDE Frameworks Version: 5.68.0
Qt Version: 5.12.8

ADDITIONAL INFORMATION
None

Comment 1 Jan Paul Batrina 2021-05-20 12:06:21 UTC

Created attachment 138596 [details]
Kate close dialog Breeze theme

Hello, are you using a theme other than breeze? From here, the buttons are labeled properly (see screenshot), and I remember this having been the case even long ago. Try opening Kate with a completely new user account session and see if the bug still occurs.

Comment 2 Steve Kerr 2021-05-20 12:46:33 UTC

I was using Kate running under xfce when I noticed this problem (for x2go performance reasons). The original installation was Kubuntu, xfce was a retro-install. I didn't realise the theme (or window manager) could affect the text in the dialog buttons. I've just retested this under Plasma (with Breeze theme) and I see Save/Discard as you do. Thanks for following this up. 

As this is not a fault with KDE, I'll Resolve this as Not a Bug.