Bug 437130

Summary: Save assert deselecting when using custom hotkey.
Product: [Applications] krita Reporter: plissken686
Component: Tools/SelectionAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED DUPLICATE    
Severity: normal CC: alanwilson772, griffinvalley, penguinflyer2222, wstephenson
Priority: NOR Keywords: triaged
Version First Reported In: 4.4.3   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Krita Usage Log

Description plissken686 2021-05-15 04:03:38 UTC
Created attachment 138441 [details]
Krita Usage Log

SUMMARY
In addition to having the default ctrl + shift + a, I have a custom shortcut to deselect set to the ESC key. It's worked fine for a while, but lately, it only works if I first click outside of the canvas (for example, on the layers window) and then press ESC. The default command works fine without clicking outside the canvas, though.

STEPS TO REPRODUCE
1. Make a custom shortcut for deselect
2. Make a selection (ctrl + a on Windows suffices for me)
3. Press key for custom shortcut

OBSERVED RESULT
Nothing is deselected.

EXPECTED RESULT
Deselection.

SOFTWARE/OS VERSIONS
Windows: 10
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 wolthera 2021-09-09 12:58:38 UTC
Hm... I am seeing a safe assert here, which might be the cause of this: 14 May 2021 22:38:25 -0500: SAFE ASSERT (krita): "m_deselectedMask->active()" in file C:\Packaging\workspace\Krita_Release_Windows64_Build\krita\libs\image\commands\KisDeselectActiveSelectionCommand.cpp, line 47
Comment 2 Will Stephenson 2021-12-16 09:45:29 UTC
I didn't see a safe assert with 5.0.0beta5 0e4b844 on Win10
Custom deselect shortcut: Esc - behaviour reproduced
However, I think the canvas input setting for Tool Invocation Cancel is conflicting with the custom Esc shortcut. If I clear that setting in Canvas Input Settings, the custom deselect works with Esc.

If a Custom deselect shortcut without conflicts like ctrl-alt-shift-d is used, deselect works as expected.
Comment 3 Freya Lupen 2024-08-22 21:03:28 UTC
*** Bug 489742 has been marked as a duplicate of this bug. ***
Comment 4 Freya Lupen 2024-08-22 21:03:49 UTC
Since this is caused by conflicts between the Keyboard Shortcuts and Canvas Input settings, marking as a duplicate of bug 329663.

*** This bug has been marked as a duplicate of bug 329663 ***