Bug 437037

Summary:	Sometimes Global Theme KCM does not apply a theme on double-click
Product:	[Applications] systemsettings	Reporter:	Patrick Silva <bugseforuns>
Component:	kcm_lookandfeel	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	doggoofspeed, nate
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-workspace/commit/34e2541b64c05501530655090298ac6f95273063	Version Fixed/Implemented In:	5.25
Sentry Crash Report:

Description Patrick Silva 2021-05-13 11:45:36 UTC

STEPS TO REPRODUCE
1. open System Settings > Appearance
2. apply another global theme by double-clicking on it (I changed from Breeze
to Breeze Dark)
3. switch back to initial global theme (Breeze, in my case) by double-clicking
on it
4. try to apply the same global theme applied in the step 2 (Breeze Dark, in my case) by double-clicking on it 

OBSERVED RESULT
global theme double-clicked in the last step is not appied

EXPECTED RESULT
Global Theme KCM should always change global theme on double-click

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.21.80
KDE Frameworks Version: 5.83.0
Qt Version: 5.15.2
Kernel Version: 5.8.0-53-generic (64-bit)
Graphics Platform: X11

Comment 1 Patrick Silva 2021-05-13 12:00:37 UTC

Icons KCM is also affected.

Comment 2 Nate Graham 2021-05-13 17:29:32 UTC

Can reproduce.

Comment 3 Vytautas 2022-01-02 15:40:58 UTC

*** Bug 447839 has been marked as a duplicate of this bug. ***

Comment 4 Nate Graham 2022-04-19 15:24:27 UTC

Git commit 34e2541b64c05501530655090298ac6f95273063 by Nate Graham, on behalf of Dominic Hayes.
Committed on 19/04/2022 at 15:24.
Pushed by ngraham into branch 'master'.

kcms/lookandfeel: allow users to choose what part of a Global Theme to apply

Now when you click on a Global Theme, it will display a Kirigami sheet for
choosing what is applied. The user can choose individual appearance elements,
and apply the theme's desktop layout, or not.
Related: bug 409015
FIXED-IN: 5.25

M  +116  -18   kcms/lookandfeel/kcm.cpp
M  +19   -4    kcms/lookandfeel/kcm.h
M  +7    -1    kcms/lookandfeel/lnftool.cpp
M  +132  -112  kcms/lookandfeel/lookandfeelmanager.cpp
M  +41   -21   kcms/lookandfeel/lookandfeelmanager.h
A  +82   -0    kcms/lookandfeel/package/contents/ui/MoreOptions.qml     [License: LGPL(v2.0)]
A  +91   -0    kcms/lookandfeel/package/contents/ui/SimpleOptions.qml     [License: LGPL(v2.0)]
M  +98   -40   kcms/lookandfeel/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/34e2541b64c05501530655090298ac6f95273063