Bug 437006

Summary:	Softness Curve Graph under Soft Mask in the Auto Brush Tip section doesn't change after resetting or switching brushes
Product:	[Applications] krita	Reporter:	fizzyflower <brightpiepomegranate>
Component:	Brush engines	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ahab.greybeard
Priority:	NOR
Version:	4.4.3
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/graphics/krita/commit/40bcb85b16f7f50b86faabc03dede77699b829bd	Version Fixed In:
Sentry Crash Report:

Description fizzyflower 2021-05-13 02:04:16 UTC

SUMMARY

When using a brush that has the brush tip set using the softness curve graph there's almost no way to change or reset the graph. If the brush is reset to it's original state the graph stays the same. If switching to a new brush present that shares the same brush engine, the new brush inherits the same softness graph that was set on the previous brush present. 

The only way the softness graph changes is to either switch to a brush present that uses a different brush engine, switch to a brush present that already has a soft brush mask set as it's brush tip, or to restart krita. I've also observed that the softness graph doesn't change when enabled under the "Masked Brush" within the pixel brush engine. A separate graph curve can be set that's different from the one the "primary" brush tip uses under the general section. But when switching between pixel engine brushes, they can all share the same masked brush softness graph. 

STEPS TO REPRODUCE
1. Select brush 
2. Set Soft Mask Type in Auto Brush Tip and adjust curve graph
3. Switch to a different brush or Reset Brush

SOFTWARE/OS VERSIONS
Windows: Windows 10 
Linux

Comment 1 Ahab Greybeard 2021-05-18 15:40:28 UTC

I can confirm this for the May 17 5.0.0-prealpha (git 6e3a7c7) appimage.

It seems that if a brush preset does not use a soft mask, then is modified to make it use the soft mask, the changes to the soft mask curve are not regarded as 'relevant' when the brush preset is reset.

Then selection of another brush preset, that uses the same brush engine and does not use a soft mask, results in no change to the soft mask shape, if edited to use it.

Comment 2 wolthera 2021-09-19 16:56:52 UTC

Git commit 2089ec6c2093507b846083bda84cf8fe785d850f by Wolthera van Hövell tot Westerflier.
Committed on 19/09/2021 at 16:55.
Pushed by woltherav into branch 'krita/5.0'.

Add reset option to autobrush widget.

We still are missing this for text and predefined, but it's
most obvious with the autobrush.

M  +11   -0    plugins/paintops/libpaintop/kis_auto_brush_widget.cpp
M  +2    -0    plugins/paintops/libpaintop/kis_auto_brush_widget.h
M  +2    -0    plugins/paintops/libpaintop/kis_brush_selection_widget.cpp

https://invent.kde.org/graphics/krita/commit/2089ec6c2093507b846083bda84cf8fe785d850f

Comment 3 wolthera 2021-09-19 16:57:12 UTC

Git commit 40bcb85b16f7f50b86faabc03dede77699b829bd by Wolthera van Hövell, on behalf of Wolthera van Hövell tot Westerflier.
Committed on 19/09/2021 at 16:57.
Pushed by woltherav into branch 'master'.

Add reset option to autobrush widget.

We still are missing this for text and predefined, but it's
most obvious with the autobrush.


(cherry picked from commit 2089ec6c2093507b846083bda84cf8fe785d850f)

M  +11   -0    plugins/paintops/libpaintop/kis_auto_brush_widget.cpp
M  +2    -0    plugins/paintops/libpaintop/kis_auto_brush_widget.h
M  +2    -0    plugins/paintops/libpaintop/kis_brush_selection_widget.cpp

https://invent.kde.org/graphics/krita/commit/40bcb85b16f7f50b86faabc03dede77699b829bd