Bug 436952

Summary: Missing Animation Dockers due to MacOS CMake Changes
Product: [Applications] krita Reporter: Eoin O'Neill <eoinoneill1991>
Component: DockersAssignee: Halla Rempt <halla>
Status: RESOLVED FIXED    
Severity: major CC: halla
Priority: NOR    
Version First Reported In: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Eoin O'Neill 2021-05-12 03:30:21 UTC 
SUMMARY
Since commit f862034e93a62fd2538fde0efece9310e99abbf2 (found via Bisect), the animation dockers are not properly included in Krita builds (Not selectable, missing from animation workspace.) Something about changing the libraries from `SHARED` to `MODULE` has caused this regression on my Linux system.  

I only noticed this because I was debugging a resource system safe assert that was preventing me from opening files. I tried clearing my install and database, which worked, but I was missing the animation dockers that were previously there due to linking.

STEPS TO REPRODUCE
1. Clear your install folder, build folder, and various config folders.
2. Run Cmake, Build Krita fresh, Launch Krita
3. Select the `Animation` workspace, or try manually adding the dockers via the docker view menu.

SOFTWARE/OS VERSIONS
 OS: Manjaro 21.0.4 Ornara
 Kernel: x86_64 Linux 5.10.34-1-MANJARO
 Uptime: 1h 27m
 Packages: 1676
 Shell: bash 5.1.4
 Resolution: 3120x1920
 WM: sway
 GTK Theme: -theme [GTK3]
 Disk: 1.2T / 3.8T (32%)
 CPU: Intel Core i7-4770K @ 8x 3.9GHz [42.0°C]
 GPU: Radeon RX 590 Series (POLARIS10, DRM 3.40.0, 5.10.34-1-MANJARO, LLVM 11.1.0)
 RAM: 2942MiB / 11916MiB

ADDITIONAL INFORMATION
It's also worth checking whether this affects the docker / appimage bundle. So far, I've observed this issue on both Manjaro and Fedora systems.
Comment 1 Eoin O'Neill 2021-05-12 03:39:17 UTC 
Sorry, I accidentally said `SHARED` to `MODULE` in the original post, but it was actually changed the other way around in commit f862034e93a62fd2538fde0efece9310e99abbf2
Comment 2 Halla Rempt 2021-05-12 07:46:41 UTC 
Ivan, can you please take a look?