Bug 436802

Summary:	Kdenlive master, and 21.04 crash when trying to run stabilize video
Product:	[Applications] kdenlive	Reporter:	Lance Rissman <lrissman>
Component:	User Interface & Miscellaneous	Assignee:	Jean-Baptiste Mardelle <jb>
Status:	RESOLVED FIXED
Severity:	crash	CC:	berndmj, fritzibaby, julius.kuenzel, memtrix
Priority:	NOR
Version First Reported In:	21.04.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	21.04.2	Version Fixed In:	https://invent.kde.org/multimedia/kdenlive/-/commit/cf64f52756069cb13421760ce85ce49a7b18e3a3
Sentry Crash Report:

Description Lance Rissman 2021-05-08 22:52:38 UTC

SUMMARY

Program crash when selecting "stabilize video" on a clip, 

STEPS TO REPRODUCE
1. Start kdenlive
2. Add a video clip to the project bin
3. Right-click on video clip, choose clip jobs->stabilize (vidstab)

Re-produceable with master complied using craft
Re-produceable with 21.04

Works on 20.12.03

OBSERVED RESULT
Kdenlive will hang and eventually Windows will ask if you want to close the program.


EXPECTED RESULT
Dialog for stabilization will appear and work.

SOFTWARE/OS VERSIONS
Windows: Windows 10 Pro

KDE Frameworks Version: 5.81.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION

Comment 1 Lance Rissman 2021-05-08 23:31:47 UTC

Ran windbg and this is the lines related to the crash:

// Fetching effect:  "vidstab"
(2158.1ad4): Unknown exception - code 20474343 (first chance)
(2158.1ad4): Unknown exception - code 20474343 (first chance)
QEventDispatcherWin32::wakeUp: Failed to post a message (Invalid window handle.)

Comment 2 Lance Rissman 2021-05-08 23:35:00 UTC

This is the windbg output from 20.12.3 that is working. 

// Fetching effect:  "vidstab"
Asset  "vidstab"  found in the repository. Description:  "Stabilize Video (for wiggly/rolling video) (vidstab)"
XML parsing of  "vidstab" . found 16 parameters
QLocale: Default value is QVariant(double, 8) parsed: "8"
 = = SET EFFECT PARAM:  "accuracy"  =  8
QLocale: Default value is QVariant(double, 4) parsed: "4"
 = = SET EFFECT PARAM:  "shakiness"  =  4
QLocale: Default value is QVariant(double, 6) parsed: "6"
 = = SET EFFECT PARAM:  "stepsize"  =  6
QLocale: Default value is QVariant(double, 0.3) parsed: "0.3"
 = = SET EFFECT PARAM:  "mincontrast"  =  0.3
QLocale: Default value is QVariant(double, 10) parsed: "10"
 = = SET EFFECT PARAM:  "smoothing"  =  10
QLocale: Default value is QVariant(double, -1) parsed: "-1"
 = = SET EFFECT PARAM:  "maxshift"  =  -1
QLocale: Default value is QVariant(double, -1) parsed: "-1"
 = = SET EFFECT PARAM:  "maxangle"  =  -1
QLocale: Default value is QVariant(QString, "0") parsed: "0"
 = = SET EFFECT PARAM:  "crop"  =  0
QLocale: Default value is QVariant(double, 0) parsed: "0"
 = = SET EFFECT PARAM:  "zoom"  =  0
QLocale: Default value is QVariant(double, 1) parsed: "1"
 = = SET EFFECT PARAM:  "optzoom"  =  1
QLocale: Default value is QVariant(double, 0.25) parsed: "0.25"
 = = SET EFFECT PARAM:  "zoomspeed"  =  0.25
QLocale: Default value is QVariant(double, 0.8) parsed: "0.8"
 = = SET EFFECT PARAM:  "sharpen"  =  0.8
QLocale: Default value is QVariant(double, 0) parsed: "0"
 = = SET EFFECT PARAM:  "show"  =  0
QLocale: Default value is QVariant(double, 0) parsed: "0"
 = = SET EFFECT PARAM:  "tripod"  =  0
WARNING: Unknown type : "fixed"
WARNING: Unknown type : "fixed"
QLocale: Default value is QVariant(double, 1) parsed: "1"
 = = SET EFFECT PARAM:  "reload"  =  1
WARNING: Unknown type : "fixed"
WARNING: Unknown type : "fixed"
QLocale: Default value is QVariant(double, 0) parsed: "0"
 = = SET EFFECT PARAM:  "analyse"  =  0
END parsing of  "vidstab" . Number of found parameters 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
QLocale: Could not load double parameter ""
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
QLocale: Could not load double parameter ""
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
QLocale: Could not load double parameter ""
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
QLocale: Could not load double parameter ""
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
QLocale: Could not load double parameter ""
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
QLocale: Could not load double parameter ""
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
QLocale: Could not load double parameter ""
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
QLocale: Could not load double parameter ""
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14
QLocale: Could not load double parameter ""
===================================================== Requested rowCount QModelIndex(-1,-1,0x0,QObject(0x0)) 14

Comment 3 memtrix 2021-05-10 11:42:08 UTC

The same issue here :(

Comment 4 emohr 2021-05-10 17:55:10 UTC

Thank you for reporting. I can confirm this crash. 

20.12.3 is working, 21.04.0 is not working. Added to https://invent.kde.org/multimedia/kdenlive/-/issues/973

=== REG FOCUS:  false
=======

SETTING AUDIO DATA IN MON

The thread 0x240c has exited with code 0 (0x0).
QTextCursor::setPosition: Position '1' out of range
==== TESTING SELECTION END ANCHOR FROM:  -1  , MIN:  1
==== TESTING SELECTION END ANCHOR FROM:  0  , WORD:  ""
==== END POS SELECTION FOR:  ""  =  ""
==== GOT LAST FRAME:  0
=== ANCHORAs FOR :  0 ,  "" - ""  AT POS:  0
MUTEX LOCK!!!!!!!!!!!! setmodel
MUTEX UNLOCK!!!!!!!!!!!! setmodel
MUTEX LOCK!!!!!!!!!!!! loadEffects COUNT:  0
TRACK NOT IN TARGET :  2  =  (2)
The thread 0xe30 has exited with code 0 (0x0).
The thread 0x2ec0 has exited with code 0 (0x0).
The thread 0x255c has exited with code 0 (0x0).
The thread 0xfe4 has exited with code 0 (0x0).
TRACK NOT IN TARGET :  2  =  (2)
// Fetching effect:  "vidstab"
Exception thrown at 0x000007FEFCA3B87D (KernelBase.dll) in kdenlive.exe: 0x20474343 (parameters: 0x00000000226FDF90).
Exception thrown at 0x000007FEFCA3B87D (KernelBase.dll) in kdenlive.exe: 0x20474343 (parameters: 0x00000000226FDF90).
Invalid parameter passed to C runtime function.
Invalid parameter passed to C runtime function.
The thread 0x910 has exited with code 0 (0x0).

The thread 0x2304 has exited with code 3 (0x3).
QEventDispatcherWin32::wakeUp: Failed to post a message

Comment 5 emohr 2021-05-10 17:58:28 UTC

*** Bug 436839 has been marked as a duplicate of this bug. ***

Comment 6 Jean-Baptiste Mardelle 2021-05-13 09:12:54 UTC

This is a regression in MLT 6.26.1 and 7. When building with cmake the metadata for the vidstab effect is not found. I just posted a proposal patch:
https://github.com/mltframework/mlt/pull/711

The Kdenlive code should however be improved to not crash in such cases. Will work on it.

Comment 7 emohr 2021-05-15 09:21:34 UTC

@Lnace Rissman Can you try with the windows nightly build, it should be solved.

https://binary-factory.kde.org/job/Kdenlive_Nightly_mingw64/lastSuccessfulBuild/artifact/

Comment 8 Julius Künzel 2021-05-16 12:31:46 UTC

Please test. Setting to NEEDSINFO

Comment 9 memtrix 2021-05-16 12:54:13 UTC

Yes, it works fine now on 21.07.70
Solved for me :) 
Thank you!

Comment 10 Lance Rissman 2021-05-18 13:32:28 UTC

I can confirm the Nightly now works properly on Windows.  Thank you.