Summary: | DrKonqi allows users to file worthless crash reports against EOL software | ||
---|---|---|---|
Product: | [Applications] drkonqi | Reporter: | Nate Graham <nate> |
Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | adaptee, kroon, sitter |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/drkonqi/commit/dd1a8a1140a58bdff2f9facc309247faeff38eb0 | Version Fixed In: | 5.23 |
Sentry Crash Report: |
Description
Nate Graham
2021-05-03 19:31:16 UTC
The system is already there in the backend https://invent.kde.org/plasma/drkonqi/-/blob/master/src/bugzillaintegration/productmapping.cpp#L156 alas, I believe the GUI doodad is missing, and my track record with touching the dialog code has been 10/10 on fatal regressions :S *** Bug 253209 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/plasma/drkonqi/-/merge_requests/29 *** Bug 315073 has been marked as a duplicate of this bug. *** Git commit dd1a8a1140a58bdff2f9facc309247faeff38eb0 by Harald Sitter. Committed on 05/08/2021 at 09:19. Pushed by sitter into branch 'master'. prevent filing bugs against unsupported plunder new page just after bugzilla version check is used to intercept reports that target inactive products/versions super early on so as to not waste anyone's time more than necessary (arguable distros should actually disable drkonqi if they can't keep up our support window :shrug:) this is largely inspired by the version page but with slightly different ui. much like version this page cannot be moved beyond if it detects a problem. unlike version it doesn't allow retrying. the assumption here would be that if we were able to talk to bugzilla we should have gotten product data milliseconds after that so there is no real opportunity for failure here and therefore nothing a retry would change. since we now have bugzilla pages early on they switch themselves inappropriate (and thus get skipped) if bugzilla isn't used FIXED-IN: 5.23 M +2 -0 src/CMakeLists.txt A +106 -0 src/bugzillaintegration/assistantpage_bugzilla_supported_entities.cpp [License: GPL(3+eV) GPL(v3.0)] A +44 -0 src/bugzillaintegration/assistantpage_bugzilla_supported_entities.h [License: GPL(3+eV) GPL(v3.0)] M +6 -0 src/bugzillaintegration/assistantpage_bugzilla_version.cpp M +4 -0 src/bugzillaintegration/productmapping.cpp M +2 -0 src/bugzillaintegration/productmapping.h M +12 -6 src/bugzillaintegration/reportassistantdialog.cpp M +2 -1 src/bugzillaintegration/reportassistantdialog.h M +5 -0 src/bugzillaintegration/reportinterface.cpp M +1 -0 src/bugzillaintegration/reportinterface.h A +178 -0 src/bugzillaintegration/ui/assistantpage_bugzilla_supported_entities.ui M +1 -0 src/drkonqi_globals.h https://invent.kde.org/plasma/drkonqi/commit/dd1a8a1140a58bdff2f9facc309247faeff38eb0 |