Bug 436518

Summary:	Skrooge titlebar and Task Manager entry has generic icon in Wayland
Product:	[Applications] skrooge	Reporter:	skierpage <info>
Component:	general	Assignee:	Guillaume DE BURE <guillaume.debure>
Status:	RESOLVED FIXED
Severity:	minor	CC:	stephane
Priority:	NOR
Version First Reported In:	Trunk from git
Target Milestone:	25.1.0
Platform:	Flatpak
OS:	Linux
Latest Commit:	https://invent.kde.org/office/skrooge/commit/6607c51a68e00fd27fc4d15ec31afed647930d38	Version Fixed In:
Sentry Crash Report:

Description skierpage 2021-05-03 05:52:49 UTC

SUMMARY
Skrooge has a generic (W) icon in its titlebar and in the KDE Task Manager when running in kwin_wayland.

STEPS TO REPRODUCE
1. Run skrooge package or `flatpak run org.kde.skrooge`
2. Confirm Help > About Skrooge > Libraries displays "The wayland windowing system"
3. Look at its titlebar and Task Manager entry.

OBSERVED RESULT
Both Fedora 34's Skrooge 2.23.0 and the kdeapps flatpak show a generic white 'W' on orange icon.

EXPECTED RESULT
Skrooge's icon.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
KDE Plasma Version: ??
KDE Frameworks Version: 5.81.0
Qt Version: Qt 5.15.3 (built against 5.15.3)
The wayland windowing system

ADDITIONAL INFORMATION
Many other KDE applications have this issue, e.g. bug 417449, bug 424823, etc.
For comparison, SpeedCrunch flatpak app has the generic titlebar icon but its own icon in the Task Manager.

https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes#Application_Icon says "setWindowIcon() no longer works", and skrooge/main.cpp#89 calls this.

Some of my skrooge.desktop files have Icon=skrooge (/usr/share/applications/org.kde.skrooge.desktop) and others have Icon=org.kde.skrooge (/var/lib/flatpak/exports/share/applications/org.kde.skrooge.desktop and /var/lib/flatpak/app/org.kde.skrooge/x86_64/master/blahblah/files/share/applications/org.kde.skrooge.desktop), I don't know if this is relevant.

Comment 1 Bug Janitor Service 2021-12-25 18:48:21 UTC

A possibly relevant merge request was started @ https://invent.kde.org/office/skrooge/-/merge_requests/11

Comment 2 Nicolas Fella 2021-12-25 19:25:33 UTC

Git commit 6607c51a68e00fd27fc4d15ec31afed647930d38 by Nicolas Fella.
Committed on 25/12/2021 at 18:47.
Pushed by smankowski into branch 'master'.

Explicitly set desktop file name

The automatically generated desktop file name is org.skrooge.skrooge, but the desktop file is named org.kde.skrooge

Set the name explicitly to fix this

M  +1    -0    skrooge/main.cpp

https://invent.kde.org/office/skrooge/commit/6607c51a68e00fd27fc4d15ec31afed647930d38