Summary: | WindowSystem::window(WId wid) returns the wrong window | ||
---|---|---|---|
Product: | [Plasma] kwayland-integration | Reporter: | Fabian Vogt <fabian> |
Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/kwayland-integration/commit/9058eff75d11e112ccf35f723199dd458fa7b02e | Version Fixed In: |
Description
Fabian Vogt
2021-05-02 19:10:19 UTC
At least it's found. As for this bug - we definitely need to fix krunner. Super worst case, we just if guard round that call. As for this bug, I think the right call is to strip all plasmaWindowManagement from kwayland-integration to leave only things that meddle with our windows not 3rd party windows. It's a broken concept to try and retroactively fit into our old API. Only plasma should meddle with other windows, and we have native API for that so should have no regressions. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwayland-integration/-/merge_requests/6 Git commit 9058eff75d11e112ccf35f723199dd458fa7b02e by Fabian Vogt. Committed on 03/05/2021 at 09:01. Pushed by fvogt into branch 'master'. Drop functions which rely on PlasmaWindow::internalId() While that returns a WinId, those are from the compositor and not related to the internal WinIds from the calling application itself. Most uses of KWindowSystem rely on that though, and so acted on a random other window instead. M +0 -21 src/windowsystem/waylandintegration.cpp M +19 -85 src/windowsystem/windowsystem.cpp M +0 -4 src/windowsystem/windowsystem.h https://invent.kde.org/plasma/kwayland-integration/commit/9058eff75d11e112ccf35f723199dd458fa7b02e |