Bug 436487

Summary: IPTC:ObjectAttributeReference and XMP:IntellectualGenre
Product: [Applications] digikam Reporter: herb <herb.k>
Component: Plugin-Generic-MetadataEditAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, metzpinguin
Priority: NOR    
Version First Reported In: 7.3.0   
Target Milestone: ---   
Platform: unspecified   
OS: All   
Latest Commit: https://invent.kde.org/graphics/digikam/commit/cbbe13fc2d208110d823ec2c8cc3760f8b9bc8ed Version Fixed/Implemented In: 7.3.0
Sentry Crash Report:

Description herb 2021-05-02 10:04:43 UTC 
SUMMARY
Hallo,

In each of the 2 dialogs of "Item" --> "Edit Metadata..." 
- (Tab) Edit IPTC --> Properties --> Field Attribute
- (Tab) Edit XMP --> Properties -->  Field Attribute

we have a dropdownbox in order to select (22 values for) IPTC GenreCode:
Here 2 examples of such values:
- 001 - Current
- 004 - Background

(1)
When we store such value inside the image e.g.: "004 - background" only "4:" resp. "004:" is stored
But all official IPTC examples I found on IPTC-websites have always stored "004:Background"

digiKam in addition has an additional field to specify a "free text" to be added. Ok this is not described/foreseen by IPTC.
So I would like to propose for storage inside image (for both fields): "004:Background:free-text"

(2) Layout of field Edit XMP - Properties - Attribute 
Please make the width of the dropdown box bigger, in order that all characters of the possible values can be displayed

(3) Layout of field Edit IPTC - Properties - Attribute
Please shorten the width of the dropdown box and enlarge the area (on right side) for the list-elements

Thanks in advance
Best regards
herb


STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Maik Qualmann 2021-05-02 12:15:45 UTC 
The edit field that you think is the "free text" is the required input line before you press the add button. I don't think it would be common practice to include the translated text "Hintergrund" in the metadata.
We should change the size of the ComboBoxes.

Maik
Comment 2 herb 2021-05-02 12:47:27 UTC 
Hello Maik,

thanks for your comments.

The main goal of the report is to avoid that strings like "4:" or "004:" are stored inside the image.

ad:
I don't think it would be common practice to include the translated text "Hintergrund" in the metadata.

The current solution allowes to store e.g. "004:blablabla".
So why not store a translated string: e.g. "004:Background" ?

Thanks and best regards
herb
Comment 3 herb 2021-05-02 12:49:26 UTC 
(In reply to herb from comment #2)
> Hello Maik,
> 
> thanks for your comments.
> 
> The main goal of the report is to avoid that strings like "4:" or "004:" are
> stored inside the image.
> 
> ad:
> I don't think it would be common practice to include the translated text
> "Hintergrund" in the metadata.
> 
> The current solution allowes to store e.g. "004:blablabla".
> So why not store a translated string: e.g. "004:Hintergrund" ?
> 
> Thanks and best regards
> herb
Comment 4 Maik Qualmann 2021-05-02 17:10:51 UTC 
Git commit f261bd748ce1c91be1f2c7d5efea6667d24e44e1 by Maik Qualmann.
Committed on 02/05/2021 at 17:10.
Pushed by mqualmann into branch 'master'.

add genre text when edit field is empty

M  +13   -2    core/dplugins/generic/metadata/metadataedit/dialog/objectattributesedit.cpp
M  +12   -1    core/dplugins/generic/metadata/metadataedit/xmp/xmpproperties.cpp

https://invent.kde.org/graphics/digikam/commit/f261bd748ce1c91be1f2c7d5efea6667d24e44e1
Comment 5 Maik Qualmann 2021-05-02 20:50:40 UTC 
Git commit cbbe13fc2d208110d823ec2c8cc3760f8b9bc8ed by Maik Qualmann.
Committed on 02/05/2021 at 20:49.
Pushed by mqualmann into branch 'master'.

optimize dialog layout from the Metadata Edit

M  +2    -1    NEWS
M  +2    -2    core/dplugins/generic/metadata/metadataedit/dialog/multistringsedit.cpp
M  +2    -2    core/dplugins/generic/metadata/metadataedit/dialog/objectattributesedit.cpp
M  +5    -4    core/dplugins/generic/metadata/metadataedit/xmp/xmpproperties.cpp

https://invent.kde.org/graphics/digikam/commit/cbbe13fc2d208110d823ec2c8cc3760f8b9bc8ed