Bug 436432

Summary:	Changing window theme icon size applies to other themes
Product:	[Plasma] kwin	Reporter:	David <david.cortes.rivera>
Component:	decorations	Assignee:	KWin default assignee <kwin-bugs-null>
Status:	RESOLVED UPSTREAM
Severity:	normal	CC:	nicolas.fella
Priority:	NOR
Version:	5.20.5
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description David 2021-05-01 00:42:45 UTC

SUMMARY
If I change the size of the window buttons in the window theme, the change will be applied to all themes, not just to the theme that I'm editing.

STEPS TO REPRODUCE
1. Download custom window themes from the KDE store.
2. Go to System Settings -> Application Style -> Window Decorations.
3. Click the edit button for some theme other than the one that's active, and change the icon size.

OBSERVED RESULT
Nothing should happen in themes other than the one being edited.

EXPECTED RESULT
Other themes also change their icon size, including the one being currently used, despite not having been edited.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.20.5
KDE Frameworks Version: 5.78.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION

Comment 1 Nicolas Fella 2021-05-01 11:53:00 UTC

I cannot reproduce this on current master.

Which themes did you edit?
Does this happen for all themes or just a particular one?

Comment 2 David 2021-05-01 16:36:06 UTC

Did some testing and it's not between all themes, but it does affect breeze-breeze10:
https://github.com/sp1ritCS/Breeze10

Comment 3 Nicolas Fella 2021-05-01 16:45:14 UTC

There is no global button size, every theme has it's own config. Since Breeze10 is a fork from Breeze it writes to the same settings file, which means when you change Breeze10 you change Breeze too and vice versa.

Can you check what happens to e.g. Oxygen when you change Breeze10. It should not be affected.

Comment 4 David 2021-05-01 16:46:38 UTC

Oxygen is not affected, and neither is Plastik. I unfortunately uninstalled all other themes so cannot tell exactly which ones are affected.

Comment 5 Nicolas Fella 2021-05-01 16:49:47 UTC

Then I would suggest to ask the author of Breeze10 to change the config location so it does not interfere with the breeze config.

I don't see how kwin does anything wrong here.