| Summary: | Breeze SDDM theme has a very strong shadow in the clock and date texts and they look weird with lighter backgrounds | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Lua <lv215bd5> |
| Component: | Theme - Breeze | Assignee: | visual-design |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | 61kylyqt, ifs6nmho, nate, ngompa13, plasma-bugs, rdieter |
| Priority: | NOR | ||
| Version: | 5.21.4 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/9004b1911ed0e106d95d47e28fe90063071f619c | Version Fixed In: | 5.22 |
| Attachments: |
the current text shadow doesn't play well with lighter backgrounds
lockscreen text shadow comparison neon-unstable-20210509-0329 SDDM in 5.22 Breeze and Breeze Fedora |
||
Oh noes, I forgot to change add this bugreport to the wishlist, it seems I can't change this after publishing the report I don't really see the problem with that screenshot, honestly. What is it that you don't like, specifically? When the background is lighter, the shadow is too black and it looks a bit "jarring". The shadow having a little opacity would improve this. A attached an image showing a comparison between the shadow with and without opacity Created attachment 137970 [details]
lockscreen text shadow comparison
Hmm, that does look better. I wonder if it would still be visible enough on top of a near-white background or a very visually busy background. Let me experiment. Git commit 9004b1911ed0e106d95d47e28fe90063071f619c by Nate Graham. Committed on 28/04/2021 at 16:10. Pushed by ngraham into branch 'master'. Slightly soften lock and login screen shadows for light backgrounds The shadows can look rather harsh against light backgrounds; this commit softens them a little bitty bit to reduce that effect, while still preserving adequate contrast to keep the text readable. FIXED-IN: 5.22 M +6 -1 lookandfeel/contents/lockscreen/LockScreenUi.qml M +12 -2 sddm-theme/Main.qml https://invent.kde.org/plasma/plasma-workspace/commit/9004b1911ed0e106d95d47e28fe90063071f619c Great! Just a question: is bugs.kde.org the right place to inform UI enhancements? Because there's KDE Phabricator -- is it just for KDE contributors? Bugzilla is fine for proposed UI improvements. :) What it's not great at is project management and speculative or open-ended discussions. Phabricator is better for those. You can feel free to participate there! Thanks! Created attachment 138404 [details]
neon-unstable-20210509-0329
Hi! A question: can I test this change? I installed neon-unstable-20210509-0329, but the shadow is still the same.
It seems that this change got reverted. Yesterday the shadow was subtle and now I received some updates and the shadow is "harsh" again, without transparency. It did not get reverted. Can you please attach a screenshot of the problem? Created attachment 139169 [details]
SDDM in 5.22
Done!
Speaking of, maybe the shadow could be centralized to improve even more the readability. Right now the shadow is a bit located to the bottom left. It's working for me, and code inspection shows that the change is still there. If you're not seeing it, I suspect a packaging issue with your distro. I'm using Neon stable. 5.22 is now available in Fedora 34 and I'm having the same problem. The text shadow is still black. Operating System: Fedora 34 KDE Frameworks Version: 5.83.0 Qt Version: 5.15.2 Kernel Version: 5.12.11-300.fc34.x86_64 (64-bit) Graphics Platform: X11 Processors: 8 × Intel® Core™ i5-8265U CPU @ 1.60GHz Memory: 15.5 GiB of RAM Graphics Processor: Mesa Intel® UHD Graphics 620 $ plasmashell -v plasmashell 5.22.1 Can you please check again in Plasma 5.23? Fedora uses a custom SDDM theme called "Breeze Fedora". When changing it to Breeze, the new shadow opacity is displayed. I think the Fedora team didn't update the Breeze Fedora code. when changing it to "Breeze" * Created attachment 141973 [details]
Breeze and Breeze Fedora
Sounds about right; that's what happens when you fork a theme instead of just customizing the wallpaper or whatever smaller changes you wanted to make. :) Niel, is there anything we can do upstream to make it easier for distros to customize elements of the SDDM theme without needing to ship a fork? Here is the bug report in Fedora Bugzilla, this might be useful: https://bugzilla.redhat.com/show_bug.cgi?id=2008353 (In reply to Nate Graham from comment #22) > Sounds about right; that's what happens when you fork a theme instead of > just customizing the wallpaper or whatever smaller changes you wanted to > make. :) > > Niel, is there anything we can do upstream to make it easier for distros to > customize elements of the SDDM theme without needing to ship a fork? Rex and I could not figure out a way to set default backgrounds and such without forking the entire theme. Ideally, we should be able to do some kind of overlay theme instead of having to do this. All we want to do is have a default setup with our distro background and the vendor logo... :( What if a there was a way to override /usr/share/sddm/themes/breeze/theme.conf through a script or something? Then the a package could be created to execute this script when installing. (In reply to 61kylyqt from comment #25) > What if a there was a way to override > /usr/share/sddm/themes/breeze/theme.conf through a script or something? Then > the a package could be created to execute this script when installing. I don't want install-time scripts to run if we don't have to. Scripts slow down things and make it more difficult to create different kinds of custom images/derivatives. Can you please open a new bug report about that? Should be fixable/improvable/implementable. P.S. sorry for misspelling your name :/ |
Created attachment 137947 [details] the current text shadow doesn't play well with lighter backgrounds SUMMARY STEPS TO REPRODUCE 1. Use an image with light tones for the the screen lock background or SDDM background 2. Lock the screen or log out OBSERVED RESULT The text shadow is too strong. EXPECTED RESULT Text shadow with a bit of opacity. SOFTWARE/OS VERSIONS Operating System: Kubuntu 21.04 KDE Plasma Version: 5.21.4 KDE Frameworks Version: 5.80.0 Qt Version: 5.15.2 ADDITIONAL INFORMATION