Bug 436217

Summary:	Repeat modes are a bit confusing
Product:	[Applications] Elisa	Reporter:	trmdi
Component:	general	Assignee:	Matthieu Gallien <matthieu_gallien>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate
Priority:	NOR	Keywords:	usability
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/multimedia/elisa/commit/2667a6474efe55c5941898bc982d52a27e32079e	Version Fixed In:	21.08
Sentry Crash Report:

Description trmdi 2021-04-26 14:10:47 UTC

STEPS TO REPRODUCE
1. Add some songs to Playlist
2. Listen to the end of the current song
or click on the Previous/Next button on the Header Bar

OBSERVED RESULT
The current song plays again

EXPECTED RESULT
The previous/next song plays

Comment 1 trmdi 2021-04-26 14:15:54 UTC

Ah, I just find that the reason is I've been in the Repeat mode.
This is not a bug, but I think that button need some visual change to show that more clearly.

Comment 2 Nate Graham 2021-04-27 14:09:44 UTC

Git commit 2667a6474efe55c5941898bc982d52a27e32079e by Nate Graham, on behalf of Tranter Madi.
Committed on 27/04/2021 at 14:09.
Pushed by ngraham into branch 'master'.

Make Shuffle/Repeat modes more clear

Currently the buttons are a bit confusing. This commit clarifies their tooltip text and also
uses the checked state when either of the modes are active.
FIXED-IN: 21.08

M  +6    -4    src/qml/MediaPlayerControl.qml
M  +7    -5    src/qml/mobile/MobileTrackPlayer.qml

https://invent.kde.org/multimedia/elisa/commit/2667a6474efe55c5941898bc982d52a27e32079e