Bug 436162

Summary: Use icons of the same type for toolbar and menu
Product: [Applications] dolphin Reporter: popov895 <popov895>
Component: generalAssignee: Dolphin Bug Assignee <dolphin-bugs-null>
Status: RESOLVED INTENTIONAL    
Severity: normal CC: kfm-devel, nate, popov895
Priority: NOR    
Version First Reported In: 21.04.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Colored icon

Description popov895 2021-04-25 13:07:19 UTC 
Created attachment 137902 [details]
Colored icon

SUMMARY

After updating to a KDE Gear 21.04.0, I noticed that the icon for "Open Terminal" action became colored, although before that it was monochrome. Please don't mix icon types, use either monochrome or color, otherwise it looks bad.

https://develop.kde.org/hig/style/icons/monochrome/action/

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: KDE neon 5.21 User Edition / X11
KDE Plasma Version: 5.21.4
KDE Frameworks Version: 5.81.0
KDE Gear: 21.04.0
Qt Version: 5.15.2
Comment 1 popov895 2021-04-25 13:09:34 UTC 
Here's the commit that changed this icon:
https://invent.kde.org/system/dolphin/commit/154843406de7855f845534f3e13612d258558827
Comment 2 Nate Graham 2021-04-25 14:33:41 UTC 
It's colored because it actually opens another app, so we show the app's icon.
Comment 3 popov895 2021-04-25 16:11:52 UTC 
Let me disagree with you. "Open Terminal" action opens my default terminal app, which is not always Konsole. So, we need to either show the icon of my default terminal app or a generic icon for terminal apps.
Comment 4 Nate Graham 2021-04-25 16:50:03 UTC 
Fair enough. It seems reasonable for the icon and text to match your default terminal app. So it would say, "Open Konsole" or "Open Terminator" or whatever.

Can you file a new bug report for that? Thanks!