| Summary: | Current review sorting algorithm can cause... problems | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Nate Graham <nate> |
| Component: | discover | Assignee: | Dan Leinir Turthra Jensen <leinir> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aleixpol |
| Priority: | NOR | Keywords: | usability |
| Version First Reported In: | 5.21.4 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=462652 | ||
| Latest Commit: | https://invent.kde.org/plasma/discover/-/commit/bd03ada4e222c0039f42d3f94eda74783413aa87 | Version Fixed/Implemented In: | 6.0 |
| Sentry Crash Report: | |||
| Attachments: | Probably not very helpful | ||
None of those three are very helpful compared to better reviews available, in fact. A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/672 Git commit bd03ada4e222c0039f42d3f94eda74783413aa87 by Marco Martin. Committed on 30/10/2023 at 11:03. Pushed by mart into branch 'master'. Sort Reviews We have a score about comment as "usefulness" use it for sorting, and add 3 options for sorting: "Relevance" (user facing for usefulness) rating (best to worst) and date (recent to old) Adapt the header layout to fit the button sending the optional comment "install to write a review" on a new line when it doesn't fit   M +3 -1 discover/qml/ApplicationPage.qml M +0 -2 discover/qml/ReviewDelegate.qml M +89 -15 discover/qml/ReviewsPage.qml M +7 -0 libdiscover/ReviewsBackend/Review.cpp M +3 -0 libdiscover/ReviewsBackend/Review.h M +33 -0 libdiscover/ReviewsBackend/ReviewsModel.cpp M +7 -0 libdiscover/ReviewsBackend/ReviewsModel.h M +45 -5 libdiscover/appstream/OdrsReviewsBackend.cpp M +1 -0 libdiscover/backends/KNSBackend/KNSReviews.cpp https://invent.kde.org/plasma/discover/-/commit/bd03ada4e222c0039f42d3f94eda74783413aa87 |
Created attachment 137806 [details] Probably not very helpful See attached screenshot. I can't tell by looking at the image what sorting algorithm we're using, but whatever it is, it seems to need some adjustment so that reviews like that can never appear in the top three. :)