| Summary: | Issue with crashed when Maximize Konsole | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | chance <changze> |
| Component: | history | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | cbc.alves, kde, nate |
| Priority: | NOR | ||
| Version: | 21.03.80 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/utilities/konsole/commit/ed2a9a9e3c3e69f4611c61716f51bb7dc3f5e11f | Version Fixed In: | 21.04.01 |
| Sentry Crash Report: | |||
| Attachments: | There is just one line, but more than 60000 characters in tmp.log. | ||
ASSERT: "_text != nullptr" in file /Volumes/Devel/KDE/src/kde/applications/konsole/src/history/compact/CompactHistoryLine.cpp, line 130 set the scrollback to the default 1000 lines to trigger This is the commit that causes this https://invent.kde.org/utilities/konsole/-/commit/4f1864abf2bad81925540c6c3b24e6058af2a4fd Yea, _blockLength isn't big enough to handle it. 262400 (new_length*sizeof(unit)) is bigger than 262144 (4096*64) A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/382 Git commit 1684952d3441b270386f6c2b7be2f711769aa2e6 by Carlos Alves. Committed on 28/04/2021 at 12:34. Pushed by hindenburg into branch 'master'. Make CompactHistoryBlock size variable When needed CompactHistoryBlock can now increase from 256kb to a bigger size. M +9 -3 src/history/compact/CompactHistoryBlock.cpp M +1 -1 src/history/compact/CompactHistoryBlock.h M +1 -1 src/history/compact/CompactHistoryBlockList.cpp M +2 -2 src/history/compact/CompactHistoryLine.h https://invent.kde.org/utilities/konsole/commit/1684952d3441b270386f6c2b7be2f711769aa2e6 Git commit ed2a9a9e3c3e69f4611c61716f51bb7dc3f5e11f by Kurt Hindenburg, on behalf of Carlos Alves. Committed on 30/04/2021 at 01:54. Pushed by hindenburg into branch 'release/21.04'. Make CompactHistoryBlock size variable (v21.04.0) When needed CompactHistoryBlock can now increase from 256kb to a bigger size. M +9 -3 src/history/compact/CompactHistoryBlock.cpp M +1 -1 src/history/compact/CompactHistoryBlock.h M +1 -1 src/history/compact/CompactHistoryBlockList.cpp M +2 -2 src/history/compact/CompactHistoryLine.h https://invent.kde.org/utilities/konsole/commit/ed2a9a9e3c3e69f4611c61716f51bb7dc3f5e11f *** Bug 436351 has been marked as a duplicate of this bug. *** |
Created attachment 137778 [details] There is just one line, but more than 60000 characters in tmp.log. SUMMARY Recently I find a situation will cause a crash. There is just one line, but more than 60000 characters in tmp.log. STEPS TO REPRODUCE 1. input "cat tmp.log" in Konsole 2. maximize Konsole OBSERVED RESULT Konsole crash EXPECTED RESULT maximize normally SOFTWARE/OS VERSIONS Konsole 21.03.80 ADDITIONAL INFORMATION In src/history/compact/CompactHistoryBlock.cpp:13, changed "_blockLength(4096 * 64)" to "_blockLength(4096 * 64 * 2)" can fix this bug.