Summary: | Kirigami.Icon is autocolored even though it should not be | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | Michail Vourlakos <mvourlakos> |
Component: | general | Assignee: | Marco Martin <notmart> |
Status: | RESOLVED DUPLICATE | ||
Severity: | normal | CC: | nate |
Priority: | NOR | ||
Version: | 5.81.0 | ||
Target Milestone: | Not decided | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Michail Vourlakos
2021-04-18 11:54:22 UTC
Can confirm; I was looking at this code recently myself, and noticed that it seemed a bit suspect. Would you be interested in submitting a merge request to fix it? Might be as simple as always disabling the auto-coloration behavior when isMask is false. (In reply to Nate Graham from comment #1) > Can confirm; I was looking at this code recently myself, and noticed that it > seemed a bit suspect. > > Would you be interested in submitting a merge request to fix it? Might be as > simple as always disabling the auto-coloration behavior when isMask is false. I think it is better to be fixed by the one that introduced guessMonochrome() function. It is pretty clear that its creator wants a code path that will apply autocoloring automatically and it is not pretty clear how it should be disabled. My thought is that this codepath was introduced for PlasmaMobile top panel that is probably autocolored so it should be better to be fix by them because anything else will probably break their current plasma mobile implementation. *** This bug has been marked as a duplicate of bug 451538 *** |