| Summary: | "rrow" doesn't find playback arrow buttons in Emoji selector, but "arrow" does | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Dan Dascalescu <ddascalescu+kde> |
| Component: | Emoji Selector | Assignee: | Faisal Mujawar <faisal.mujawar4> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | 4wy78uwh, benson_muite, bharadwaj.raju777, faisal.mujawar4, fanzhuyifan, nate |
| Priority: | NOR | Keywords: | junior-jobs, usability |
| Version: | 5.93.0 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-desktop/-/commit/49abd66b12bbc4111d5e32bdef07b3c96c46698d | Version Fixed In: | 6.2.3 |
| Sentry Crash Report: | |||
| Attachments: | Screencast | ||
Wow that's weird. Can confirm. Right now they don't come up even with "arrow", and "arrow" doesn't seem to be mentioned in their description. Currently the annotations are stored as a StringList, and we just do idx.data(AbstractEmojiModel::AnnotationsRole).toStringList().contains(m_search, Qt::CaseInsensitive); (See plasma-desktop/emojier/emojierplugin.cpp) Hi! Can I work on this bug? Definitely. Feel free to ask in the matrix channels if you ever need help https://community.kde.org/Matrix A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2605 Git commit 823b252ec107c2a73e831ee37d435ed83281b4cc by Fushan Wen, on behalf of Eren Karakas. Committed on 29/10/2024 at 02:56. Pushed by fusionfuture into branch 'master'. emojier: do substring search in emoji annotations as well .contains behaves differently on emoji.descriptions and emoji.annotations since one is QString and one is QStringList. Use .filter to get the same substring check behavior. M +1 -1 emojier/emojierplugin.cpp https://invent.kde.org/plasma/plasma-desktop/-/commit/823b252ec107c2a73e831ee37d435ed83281b4cc Git commit 49abd66b12bbc4111d5e32bdef07b3c96c46698d by Fushan Wen. Committed on 29/10/2024 at 03:15. Pushed by fusionfuture into branch 'Plasma/6.2'. emojier: do substring search in emoji annotations as well .contains behaves differently on emoji.descriptions and emoji.annotations since one is QString and one is QStringList. Use .filter to get the same substring check behavior. (cherry picked from commit 823b252ec107c2a73e831ee37d435ed83281b4cc) Co-authored-by: Eren Karakas <erenkarakas202@hotmail.com> M +1 -1 emojier/emojierplugin.cpp https://invent.kde.org/plasma/plasma-desktop/-/commit/49abd66b12bbc4111d5e32bdef07b3c96c46698d |
Created attachment 137644 [details] Screencast Searching for "rrow" finds blue arrows, but not the playback arrow emojis. Typing "arrow" does find the playback ones as well.