|Summary:||Sidebar list items on top have different icon alignment from the ones on bottom|
|Product:||[Applications] Discover||Reporter:||andreas_k <andreas_k>|
|Component:||discover||Assignee:||Dan Leinir Turthra Jensen <leinir>|
|Latest Commit:||https://invent.kde.org/frameworks/kirigami/commit/0f9ea7b33732c630d577cc261053d04f6600d62c||Version Fixed In:||5.82|
|Attachments:||Discover updated UI|
Description andreas_k 2021-04-15 17:23:40 UTC
Created attachment 137641 [details] Discover updated UI Some part's of plasma aren't perfect aligned. 1. Update command in sidebar and update "toolbar" when selected update page Can the Update element in the sidebar (bottom last one) have the same height than the bottom "toolbar" at the update page, which is the same height than the top "toolbar" area. 2. Home button The home button is left to the Search. If you select something in the sidebar, there will be an back button (icon + label) visible. as this item is for navigation, it would be way more usefull and reasonable to homve the Home button to the Back "navigation", because home is also kind of navigation. In addition the top Search element look way better and is more balanced. 3. Sidebar elements aren't vertical align The back navigation label isn't align to the other labels (Accessibility, Accessories, ...) The < icon from back navigation elment isn't align with the icons from Accessibility, Accessories, ...
Comment 1 Nate Graham 2021-04-16 16:50:03 UTC
#1 is not really fixable, and not a thing we would do even if it were possible to fix, because they are different UI elements. There's no logical reason why a list item should be the exact same height as a toolbar. #2 Doesn't really make sense IMO. Going back is not the same thing as going to the home page. And we would lose the ability to go back to the home page from any arbitrary page in the UI #3 is a legitimate issue. I'll see if it's fixable.
Comment 2 Nate Graham 2021-04-16 17:38:01 UTC
Git commit 0f9ea7b33732c630d577cc261053d04f6600d62c by Nate Graham. Committed on 16/04/2021 at 17:37. Pushed by ngraham into branch 'master'. [BasicListItem] Don't unconditionally apply leading and trailing padding Right now the leadingPadding and trailingPadding properties are being unconditionally applied even if there are no leading or trailing items. Let's only apply them if there are leading or trailing items. This fixes the problem of BasicListItems witout leading items having their icons indented too far to the right. FIXED-IN: 5.82 M +2 -2 src/controls/BasicListItem.qml https://invent.kde.org/frameworks/kirigami/commit/0f9ea7b33732c630d577cc261053d04f6600d62c
Comment 3 Nate Graham 2021-04-16 17:43:55 UTC
It was fixable. :)