Bug 435481

Summary:	Bring back non-full-height top header separator
Product:	[Frameworks and Libraries] frameworks-kirigami	Reporter:	Nate Graham <nate>
Component:	general	Assignee:	Marco Martin <notmart>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version:	5.80.0
Target Milestone:	Not decided
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/frameworks/kirigami/-/commit/ef4aeb77da2761d3a3df2e3bdfa096a81c0ea3a3	Version Fixed In:	Frameworks 6.1
Sentry Crash Report:
Attachments:	What it used to look like

Description Nate Graham 2021-04-07 19:32:39 UTC

Created attachment 137413 [details]
What it used to look like

Aeons ago, Kirigami used to have a really nice non-full-height separator in its toolbar between adjacent pages/sections. An example can be see in the attachment at Bug 403698, and I am attaching another image too.

This old style was quite nice, and looked better with color schemes that have the titlebar and window content share the same color--such as Breeze Dark and Breeze light, which is now the default color scheme.

I don't know why this style was removed (my guess is that it was code-heavy and fragile) but it would be nice to bring it back

Comment 1 Nate Graham 2024-02-29 16:43:30 UTC

Fixed by Carl Schwan with https://invent.kde.org/frameworks/kirigami/-/commit/ef4aeb77da2761d3a3df2e3bdfa096a81c0ea3a3!

Note that it's not fixed yet in System Settings because System Settings does a custom thing and therefore doesn't inherit that fix automatically. This will have to be fixed separately.

Comment 2 Carl Schwan 2024-02-29 17:05:16 UTC

Git commit 6b636e5bb83f79e3d7f41fc5f1aa7a8ffc06690b by Carl Schwan.
Committed on 29/02/2024 at 17:05.
Pushed by carlschwan into branch 'Plasma/6.0'.

Improve page separator in header


(cherry picked from commit eb16b1eb0d2f3d9bbaef6d7a28518972ee893329)

M  +18   -0    app/sidebar/qml/Main.qml

https://invent.kde.org/plasma/systemsettings/-/commit/6b636e5bb83f79e3d7f41fc5f1aa7a8ffc06690b

Comment 3 Carl Schwan 2024-02-29 17:05:55 UTC

Git commit eb16b1eb0d2f3d9bbaef6d7a28518972ee893329 by Carl Schwan.
Committed on 29/02/2024 at 17:04.
Pushed by carlschwan into branch 'master'.

Improve page separator in header

M  +18   -0    app/sidebar/qml/Main.qml

https://invent.kde.org/plasma/systemsettings/-/commit/eb16b1eb0d2f3d9bbaef6d7a28518972ee893329