Bug 435446

Summary: Player controls get squished with extremely narrow window widths in desktop view
Product: [Applications] Elisa Reporter: trmdi
Component: generalAssignee: Matthieu Gallien <matthieu_gallien>
Status: RESOLVED FIXED    
Severity: normal CC: nate
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 21.04.0
Sentry Crash Report:
Attachments: screenshot

Description trmdi 2021-04-07 03:20:58 UTC
Created attachment 137395 [details]
screenshot

When the window's width is very short, the control bar need to be re-laid-out.
Please see the screenshot.
Comment 1 Nate Graham 2021-04-07 15:10:13 UTC
Yeah.

However is there actually a use case for making the window so small outside of being used on a phone (for which there is a separate mobile layout)? Maybe we should just increase the minimum window width for the desktop view.
Comment 2 trmdi 2021-04-08 03:35:30 UTC
(In reply to Nate Graham from comment #1)
> Yeah.
> 
> However is there actually a use case for making the window so small outside
> of being used on a phone (for which there is a separate mobile layout)?
> Maybe we should just increase the minimum window width for the desktop view.

I'm not sure, don't know if it is also used on mobile.
Comment 3 Nate Graham 2021-04-08 18:35:22 UTC
It's not; there's a separate mobile view.
Comment 4 Bug Janitor Service 2021-04-08 18:47:20 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/227
Comment 5 Nate Graham 2021-04-09 02:47:53 UTC
Git commit 1889b811982a53725fb30113fcba6e33ecb2a4d2 by Nate Graham.
Committed on 08/04/2021 at 18:45.
Pushed by ngraham into branch 'release/21.04'.

Larger minimum window width for desktop mode

Any smaller than about 620, and the player controls become unusable.
FIXED-IN: 21.04.0

M  +1    -1    src/qml/ElisaMainWindow.qml

https://invent.kde.org/multimedia/elisa/commit/1889b811982a53725fb30113fcba6e33ecb2a4d2