Bug 435425

Summary:	Checkboxes get messed up if the toolbutton styling in the Plasma Style involves solid backgrounds
Product:	[Frameworks and Libraries] libplasma	Reporter:	The Feren OS Dev <ferenosdev>
Component:	components	Assignee:	Marco Martin <notmart>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	nate, plasma-bugs-null
Priority:	NOR
Version First Reported In:	5.80.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description The Feren OS Dev 2021-04-06 14:09:23 UTC

SUMMARY
Suffice to say, if the 'toolbutton' styling in a Plasma Style involves a solid hover look, when hovering over checkboxes or if checkboxes are focused, the solid toolbutton styling wrongly overlays the checkbox.

STEPS TO REPRODUCE
1. Make a Plasma Style with a toolbutton hover style that is opaque/solid in appearance
2. Apply the Plasma Style
3. Hover or focus on a checkbox

OBSERVED RESULT
Toolbutton styling is applied, which completely conceals the checkbox

EXPECTED RESULT
Toolbutton styling isn't applied so as to not conceal the checkbox

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: KDE neon 5.21.2 (first seen in 5.20.0)
(available in About System)
KDE Plasma Version: 5.21.2 (first seen in 5.20.0)
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2

ADDITIONAL INFORMATION
Plasma Styles like Feren OS's employ a solid toolbutton hover style to be consistent with the hovered appearance of toolbuttons in the Feren OS Application Style.

Toolbuttons refer to buttons with a background-less appearance on their normal states, and the 'toolbutton' element in Plasma Styles.

Comment 1 Nate Graham 2021-04-07 15:59:25 UTC

Is this with a Plasmacomponents3 checkbox, or with a PlasmaComponents2 one? Can you attach a screenshot that shows the problem?

Comment 2 Nate Graham 2021-04-07 16:02:46 UTC

I that for the indicator, we use a PlasmaCore.FrameSvgItem with:

        imagePath: "widgets/button"
        prefix: "normal"

Which looks weird, but the "normal" prefix is for pushbuttons, not toolbuttons AFAIK.

However in ButtonHover.qml, I see this:

    // TODO KF6: If "toolbutton-hover" is made to behave like "hover",
    // put the logic for flat button hover effects here.

Could be related.

But the bottom line is that this is *trying* to render the checkbox to look like a button, not a toolbutton.

Comment 3 Bug Janitor Service 2021-04-22 04:33:22 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 4 Bug Janitor Service 2021-05-07 04:33:41 UTC

This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!