Bug 435330

Summary: Sub operations view's tab confusingly looks identical to just "Operations"
Product: [Applications] skrooge Reporter: skierpage <info>
Component: generalAssignee: Guillaume DE BURE <guillaume.debure>
Status: RESOLVED FIXED    
Severity: minor CC: stephane
Priority: NOR    
Version First Reported In: Trunk from git   
Target Milestone: 25.1.0   
Platform: Flatpak   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Sub operations tab and header.

Description skierpage 2021-04-04 01:27:31 UTC
Created attachment 137320 [details]
Sub operations tab and header.

SUMMARY
I needed to compare categorized operations with their sub operations. I realized the two tabs have the same name.

STEPS TO REPRODUCE
1. In Skrooge's Pages panel, click Operations.
2. Choose View > New Tab, then Choose Go > Open sub operations...

OBSERVED RESULT
See attachment. Both tabs are labeled "Operations" and have the same icon.
The Sub operations tab has a big header with a huge split icon and the bold text "Sub operations".

EXPECTED RESULT
The sub operations tab should be labeled "Sub operations" and should probably have the split icon that its Go > Open sub operations... menu item has, so you can tell the tabs apart. See attachment.


SOFTWARE/OS VERSIONS

Linux/KDE Plasma: 
KDE Plasma Version: n/a
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2 xcb

ADDITIONAL INFORMATION

There's a similar bug/confusion between the view you get from the "Open operations with..." and "Open sub operations with..." menu items in an operations view. E.g. Open operations with... > Category = <category of the operation you clicked on> and Open sub operations with... > Category = <category of the operation you clicked on> have the same folder icon and bold text in the big header, as well as identical tabs.
Comment 1 Stephane MANKOWSKI 2021-04-16 19:50:20 UTC
Git commit 326558a560df52f853b026b3bfb0fcb667af2351 by Stephane MANKOWSKI.
Committed on 16/04/2021 at 19:50.
Pushed by smankowski into branch 'master'.

Sub operations view's tab confusingly looks identical to just "Operations"

M  +1    -0    CHANGELOG
M  +1    -1    plugins/generic/skg_dashboard/skgdashboardwidget.cpp
M  +3    -3    plugins/skrooge/skrooge_operation/skgoperationplugin.cpp
M  +1    -1    plugins/skrooge/skrooge_search/skgsearchpluginwidget.cpp
M  +1    -1    skgbasegui/skgmainpanel.cpp

https://invent.kde.org/office/skrooge/commit/326558a560df52f853b026b3bfb0fcb667af2351