Bug 435297

Summary: [Master] Cannot transform layer if its transform mask is hidden, along with a safe assert
Product: [Applications] krita Reporter: tomtomtomreportingin
Component: Tools/TransformAssignee: Dmitry Kazakov <dimula73>
Status: RESOLVED FIXED    
Severity: normal CC: dimula73
Priority: NOR    
Version First Reported In: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Debian unstable   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description tomtomtomreportingin 2021-04-03 08:03:50 UTC 
git 26f1427

SUMMARY
In master, Krita prevents you from transforming a layer if a transform mask attached to it is hidden.

STEPS TO REPRODUCE
1. Draw something.
2. Add a transform mask.
3. (Bonus: Transforming the transform mask to be elsewhere will make step 6 trigger a safe assert. In stable Krita, step 6 would just make the transform rendering invisible.)
4. Hide the transform mask.
5. Select the original layer.
6. Attempt to transform it.

OBSERVED RESULT
Krita says it cannot transform an empty layer.

EXPECTED RESULT
The original layer should be able to be transformed if the transform mask is hidden.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Debian sid
KDE Plasma Version: 5.20.5
KDE Frameworks Version: 5.78.0
Qt Version: 5.15.2
Comment 1 tomtomtomreportingin 2021-04-03 08:04:42 UTC 
Oh, and the safe assert:

SAFE ASSERT (krita): "isChangingTransformMask || m_d->overriddenCommand" in file /home/name/kritadev/krita/plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.cpp, line 878
Comment 2 Dmitry Kazakov 2021-07-17 11:13:07 UTC 
This bug has been fixed in commits d0a4a3e425bc5e331e39e019251778b07e3cfff6 and 627d7405ed10b692ff49d716ef4f8b18be89d3e6