Bug 435273

Summary:	Crash/assert + freeze on switching visibility in KisBusyWaitBroker
Product:	[Applications] krita	Reporter:	Tiar <tamtamy.tymona>
Component:	Layer Stack	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	halla, wstephenson
Priority:	NOR
Version First Reported In:	nightly build (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Crashlog for all threads

Description Tiar 2021-04-02 17:26:05 UTC

Created attachment 137277 [details]
Crashlog for all threads

SUMMARY
Well, I was switching visibility of layers, possibly removing some layers and switching visibility on others, and I've got a "safe assert". I cannot get the exact backtrace because the safe assert dialog wasn't working correctly... I had to use ctrl+C in the gdb.

I had the same situation with safe asserts before here: bug 434647

And my cmake options are: cmake ../krita -DCMAKE_INSTALL_PREFIX=$DIR/install -DCMAKE_BUILD_TYPE=Debug -DKRITA_DEVS=ON -DHIDE_SAFE_ASSERTS=off -DPYTHON_EXECUTABLE=/usr/bin/python3 -DECM_ENABLE_SANITIZERS='' -DLIBMYPAINT_INCLUDE_DIR=/usr/include/libmypaint/ -DFETCH_TRANSLATIONS=ON

OBSERVED RESULT
- I got a safe assert

     02 Apr 2021 05:41:05 +0200: SAFE ASSERT (krita): "!m_d->waitingOnImages.contains(image)" in file /home/tymon/kritadev/krita/libs/image/KisBusyWaitBroker.cpp, line 52

- The safe assert dialog showed up, giving me a choice of Ignore and Abort
- Clicking on the safe assert dialog didn't do anything... (neither Ignore nor Abort got me any reaction. Note that I did get multiple safe assert dialogs in the row before, but then they would close and another would open, and in this situation the dialog would just... not react to any input. It is possible to move it around, I believe, but not to click on any button, and Tab and/or Enter doesn't do anything either).
- Gdb didn't notice the situation: it looked as if Krita was still working correctly.
- I had to use ctrl+C in the gdb to get the backtrace.

EXPECTED RESULT
- No crash
- safe assert dialog should react to clicks
- and if not, then gdb should notice that Krita crashed
(which is why I suspect a freeze just after the safe assert?)

SOFTWARE/OS VERSIONS
Krita

 Version: 5.0.0-prealpha (git eebf7e3)
 Languages: pl, pl_PL, pl
 Hidpi: true

Qt

  Version (compiled): 5.12.8
  Version (loaded): 5.12.8

ADDITIONAL INFORMATION
Backtrace after ctrl+C:


^C
Thread 1 "krita" received signal SIGINT, Interrupt.
syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
38	../sysdeps/unix/sysv/linux/x86_64/syscall.S: Nie ma takiego pliku ani katalogu.
(gdb) bt
#0  syscall () at ../sysdeps/unix/sysv/linux/x86_64/syscall.S:38
#1  0x00007ffff4465c75 in QBasicMutex::lockInternal() () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#2  0x00007ffff5aef017 in QMutexLocker::QMutexLocker(QBasicMutex*) (m=<optimized out>, this=<synthetic pointer>) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qmutex.h:206
#3  KisBusyWaitBroker::notifyWaitOnImageStarted(KisImage*) (this=0x7ffff5f09a08 <(anonymous namespace)::Q_QGS_s_instance::innerFunction()::holder>, image=<optimized out>, image@entry=0x555586f60c20)
    at /home/tymon/kritadev/krita/libs/image/KisBusyWaitBroker.cpp:50
#4  0x00007ffff5b9b85d in KisImage::waitForDone() (this=this@entry=0x555586f60c20) at /home/tymon/kritadev/krita/libs/image/kis_image.cc:1761
#5  0x00007ffff5ba8907 in KisImage::~KisImage() (this=0x555586f60c20, __in_chrg=<optimized out>) at /home/tymon/kritadev/krita/libs/image/kis_image.cc:271
#6  0x00007ffff5ba8d6d in KisImage::~KisImage() (this=0x555586f60c20, __in_chrg=<optimized out>) at /home/tymon/kritadev/krita/libs/image/kis_image.cc:266
#7  0x00007fffd03188fb in KisSharedPtr<KisImage>::deref(KisSharedPtr<KisImage> const*, KisImage*) (sp=<optimized out>, t=0x555586f60c20) at /home/tymon/kritadev/krita/libs/global/kis_shared_ptr.h:191
#8  KisSharedPtr<KisImage>::deref(KisSharedPtr<KisImage> const*, KisImage*) (sp=<synthetic pointer>, t=0x555586f60c20) at /home/tymon/kritadev/krita/libs/global/kis_shared_ptr.h:191
#9  KisSharedPtr<KisImage>::deref() const (this=<synthetic pointer>) at /home/tymon/kritadev/krita/libs/global/kis_shared_ptr.h:213
#10 KisSharedPtr<KisImage>::~KisSharedPtr() (this=<synthetic pointer>, __in_chrg=<optimized out>) at /home/tymon/kritadev/krita/libs/global/kis_shared_ptr.h:97
#11 KisStoryboardThumbnailRenderScheduler::renderNextFrame() (this=0x55555c381940) at /home/tymon/kritadev/krita/plugins/dockers/storyboarddocker/KisStoryboardThumbnailRenderScheduler.cpp:127
#12 0x00007fffd02eff24 in KisStoryboardThumbnailRenderScheduler::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (_o=<optimized out>, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>)
    at /home/tymon/kritadev/build/plugins/dockers/storyboarddocker/kritastoryboarddocker_autogen/EWIEGA46WW/moc_KisStoryboardThumbnailRenderScheduler.cpp:97
#13 0x00007ffff4659300 in QMetaObject::activate(QObject*, int, int, void**) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#14 0x00007ffff4659300 in QMetaObject::activate(QObject*, int, int, void**) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#15 0x00007ffff466651e in QTimer::timeout(QTimer::QPrivateSignal) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#16 0x00007ffff4659cf5 in QObject::event(QEvent*) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#17 0x00007ffff5045a66 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#18 0x00007ffff504f0f0 in QApplication::notify(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#19 0x00007ffff702cdad in KisApplication::notify(QObject*, QEvent*) (this=<optimized out>, receiver=0x55555c3813d0, event=0x7fffffffaa70) at /home/tymon/kritadev/krita/libs/ui/KisApplication.cpp:709
#20 0x00007ffff462d93a in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#21 0x00007ffff46848b0 in QTimerInfoList::activateTimers() () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#22 0x00007ffff468519c in  () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#23 0x00007ffff19de17d in g_main_context_dispatch () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#24 0x00007ffff19de400 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#25 0x00007ffff19de4a3 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#26 0x00007ffff4685565 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#27 0x00007ffff462c4db in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#28 0x00007ffff5249c6d in QDialog::exec() () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#29 0x00007ffff5282456 in  () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#30 0x00007ffff55ea434 in kis_assert_common(char const*, char const*, int, bool, bool) (assertion=<optimized out>, file=<optimized out>, line=<optimized out>, throwException=<optimized out>, isIgnorable=<optimized out>)
    at /usr/include/x86_64-linux-gnu/qt5/QtCore/qcoreapplication.h:116
#31 0x00007ffff5aef057 in KisBusyWaitBroker::notifyWaitOnImageStarted(KisImage*) (this=0x7ffff5f09a08 <(anonymous namespace)::Q_QGS_s_instance::innerFunction()::holder>, image=<optimized out>, image@entry=0x55556d853f00)
    at /usr/include/x86_64-linux-gnu/qt5/QtCore/qhash.h:906
#32 0x00007ffff5b9b798 in KisImage::barrierLock(bool) (this=0x55556d853f00, readOnly=readOnly@entry=false) at /home/tymon/kritadev/krita/libs/image/kis_image.cc:710
#33 0x00007ffff5cdbe7b in KisLegacyUndoAdapter::addCommand(KUndo2Command*) (command=0x55557256c8a0, this=0x55556d914a30) at /home/tymon/kritadev/krita/libs/global/kis_shared_ptr.h:381
#34 KisLegacyUndoAdapter::addCommand(KUndo2Command*) (this=0x55556d914a30, command=0x55557256c8a0) at /home/tymon/kritadev/krita/libs/image/kis_legacy_undo_adapter.cpp:30
#35 0x00007ffff5a4539d in KisNodePropertyListCommand::setNodePropertiesAutoUndo(KisSharedPtr<KisNode>, KisSharedPtr<KisImage>, QList<KisBaseNode::Property>) (node=..., image=..., proplist=...)
    at /home/tymon/kritadev/krita/libs/global/kis_shared_ptr.h:167
#36 0x00007ffff6d43d6a in KisNodeManager::trySetNodeProperties(KisSharedPtr<KisNode>, KisSharedPtr<KisImage>, QList<KisBaseNode::Property>) const (this=this@entry=0x555558d6cf30, node=..., image=..., properties=...)
    at /usr/include/c++/9/bits/atomic_base.h:318
#37 0x00007ffff6d651d5 in KisNodeModel::setData(QModelIndex const&, QVariant const&, int) (this=0x55555c8159a0, index=..., value=..., role=<optimized out>) at /usr/include/c++/9/bits/atomic_base.h:318
#38 0x00007ffff4600d61 in QSortFilterProxyModel::setData(QModelIndex const&, QVariant const&, int) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#39 0x00007fffd064c92f in NodeDelegate::Private::toggleProperty(QList<KisBaseNode::Property>&, KisBaseNode::Property*, QFlags<Qt::KeyboardModifier>, QModelIndex const&)
    (this=<optimized out>, props=..., clickedProperty=<optimized out>, modifier=..., index=...) at /home/tymon/kritadev/krita/libs/image/kis_base_node.h:609
#40 0x00007fffd064d96a in NodeDelegate::editorEvent(QEvent*, QAbstractItemModel*, QStyleOptionViewItem const&, QModelIndex const&)
    (this=this@entry=0x55555c7f8000, event=event@entry=0x7fffffffbc60, model=<optimized out>, option=..., index=...) at /usr/include/x86_64-linux-gnu/qt5/QtGui/qevent.h:73
#41 0x00007fffd0654040 in NodeView::viewportEvent(QEvent*) (this=0x55555c7f2880, e=0x7fffffffbc60) at /home/tymon/kritadev/krita/plugins/dockers/layerdocker/NodeView.cpp:266
#42 0x00007ffff462d64b in QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#43 0x00007ffff5045a55 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#44 0x00007ffff504f343 in QApplication::notify(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#45 0x00007ffff702cdad in KisApplication::notify(QObject*, QEvent*) (this=<optimized out>, receiver=0x55555c7e77d0, event=0x7fffffffbc60) at /home/tymon/kritadev/krita/libs/ui/KisApplication.cpp:709
#46 0x00007ffff462d93a in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
--Type <RET> for more, q to quit, c to continue without paging--
#47 0x00007ffff504e457 in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool, bool) () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#48 0x00007ffff50a435d in  () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#49 0x00007ffff50a71ec in  () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#50 0x00007ffff5045a66 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#51 0x00007ffff504f0f0 in QApplication::notify(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#52 0x00007ffff702cdad in KisApplication::notify(QObject*, QEvent*) (this=<optimized out>, receiver=0x55555caca700, event=0x7fffffffc160) at /home/tymon/kritadev/krita/libs/ui/KisApplication.cpp:709
#53 0x00007ffff462d93a in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#54 0x00007ffff4a167d3 in QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) () at /lib/x86_64-linux-gnu/libQt5Gui.so.5
#55 0x00007ffff4a1810b in QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*) () at /lib/x86_64-linux-gnu/libQt5Gui.so.5
#56 0x00007ffff49f235b in QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /lib/x86_64-linux-gnu/libQt5Gui.so.5
#57 0x00007fffee91632e in  () at /lib/x86_64-linux-gnu/libQt5XcbQpa.so.5
#58 0x00007ffff19de17d in g_main_context_dispatch () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#59 0x00007ffff19de400 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#60 0x00007ffff19de4a3 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#61 0x00007ffff46855e4 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#62 0x00007ffff6c67f3a in KisDelayedSaveDialog::blockIfImageIsBusy() (this=this@entry=0x7fffffffc540) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qflags.h:120
#63 0x00007ffff70890a6 in (anonymous namespace)::busyWaitWithFeedback(KisImageSP) (image=...) at /home/tymon/kritadev/krita/libs/ui/KisPart.cpp:123
#64 0x00007ffff708a327 in std::_Function_handler<void (KisSharedPtr<KisImage>), void (*)(KisSharedPtr<KisImage>)>::_M_invoke(std::_Any_data const&, KisSharedPtr<KisImage>&&) (__functor=..., __args#0=...)
    at /usr/include/c++/9/bits/atomic_base.h:318
#65 0x00007ffff5aef0e6 in std::function<void (KisSharedPtr<KisImage>)>::operator()(KisSharedPtr<KisImage>) const (__args#0=..., this=<optimized out>) at /usr/include/c++/9/bits/std_function.h:683
#66 KisBusyWaitBroker::notifyWaitOnImageStarted(KisImage*) (this=0x7ffff5f09a08 <(anonymous namespace)::Q_QGS_s_instance::innerFunction()::holder>, image=<optimized out>, image@entry=0x55556d853f00)
    at /home/tymon/kritadev/krita/libs/image/KisBusyWaitBroker.cpp:57
#67 0x00007ffff5b9b798 in KisImage::barrierLock(bool) (this=0x55556d853f00, readOnly=readOnly@entry=false) at /home/tymon/kritadev/krita/libs/image/kis_image.cc:710
#68 0x00007ffff5cdbe7b in KisLegacyUndoAdapter::addCommand(KUndo2Command*) (command=0x555567d60140, this=0x55556d914a30) at /home/tymon/kritadev/krita/libs/global/kis_shared_ptr.h:381
#69 KisLegacyUndoAdapter::addCommand(KUndo2Command*) (this=0x55556d914a30, command=0x555567d60140) at /home/tymon/kritadev/krita/libs/image/kis_legacy_undo_adapter.cpp:30
#70 0x00007ffff5a4539d in KisNodePropertyListCommand::setNodePropertiesAutoUndo(KisSharedPtr<KisNode>, KisSharedPtr<KisImage>, QList<KisBaseNode::Property>) (node=..., image=..., proplist=...)
    at /home/tymon/kritadev/krita/libs/global/kis_shared_ptr.h:167
#71 0x00007ffff6d43d6a in KisNodeManager::trySetNodeProperties(KisSharedPtr<KisNode>, KisSharedPtr<KisImage>, QList<KisBaseNode::Property>) const (this=this@entry=0x555558d6cf30, node=..., image=..., properties=...)
    at /usr/include/c++/9/bits/atomic_base.h:318
#72 0x00007ffff6d651d5 in KisNodeModel::setData(QModelIndex const&, QVariant const&, int) (this=0x55555c8159a0, index=..., value=..., role=<optimized out>) at /usr/include/c++/9/bits/atomic_base.h:318
#73 0x00007ffff4600d61 in QSortFilterProxyModel::setData(QModelIndex const&, QVariant const&, int) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#74 0x00007fffd064c92f in NodeDelegate::Private::toggleProperty(QList<KisBaseNode::Property>&, KisBaseNode::Property*, QFlags<Qt::KeyboardModifier>, QModelIndex const&)
    (this=<optimized out>, props=..., clickedProperty=<optimized out>, modifier=..., index=...) at /home/tymon/kritadev/krita/libs/image/kis_base_node.h:609
#75 0x00007fffd064d96a in NodeDelegate::editorEvent(QEvent*, QAbstractItemModel*, QStyleOptionViewItem const&, QModelIndex const&)
    (this=this@entry=0x55555c7f8000, event=event@entry=0x7fffffffd3d0, model=<optimized out>, option=..., index=...) at /usr/include/x86_64-linux-gnu/qt5/QtGui/qevent.h:73
#76 0x00007fffd0654040 in NodeView::viewportEvent(QEvent*) (this=0x55555c7f2880, e=0x7fffffffd3d0) at /home/tymon/kritadev/krita/plugins/dockers/layerdocker/NodeView.cpp:266
#77 0x00007ffff462d64b in QCoreApplicationPrivate::sendThroughObjectEventFilters(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#78 0x00007ffff5045a55 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#79 0x00007ffff504f343 in QApplication::notify(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#80 0x00007ffff702cdad in KisApplication::notify(QObject*, QEvent*) (this=<optimized out>, receiver=0x55555c7e77d0, event=0x7fffffffd3d0) at /home/tymon/kritadev/krita/libs/ui/KisApplication.cpp:709
#81 0x00007ffff462d93a in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#82 0x00007ffff504e457 in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool, bool) () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#83 0x00007ffff50a435d in  () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#84 0x00007ffff50a71ec in  () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#85 0x00007ffff5045a66 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#86 0x00007ffff504f0f0 in QApplication::notify(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Widgets.so.5
#87 0x00007ffff702cdad in KisApplication::notify(QObject*, QEvent*) (this=<optimized out>, receiver=0x55555caca700, event=0x7fffffffd8d0) at /home/tymon/kritadev/krita/libs/ui/KisApplication.cpp:709
#88 0x00007ffff462d93a in QCoreApplication::notifyInternal2(QObject*, QEvent*) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#89 0x00007ffff4a167d3 in QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) () at /lib/x86_64-linux-gnu/libQt5Gui.so.5
#90 0x00007ffff4a1810b in QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*) () at /lib/x86_64-linux-gnu/libQt5Gui.so.5
#91 0x00007ffff49f235b in QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /lib/x86_64-linux-gnu/libQt5Gui.so.5
#92 0x00007fffee91632e in  () at /lib/x86_64-linux-gnu/libQt5XcbQpa.so.5
#93 0x00007ffff19de17d in g_main_context_dispatch () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#94 0x00007ffff19de400 in  () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
#95 0x00007ffff19de4a3 in g_main_context_iteration () at /lib/x86_64-linux-gnu/libglib-2.0.so.0
--Type <RET> for more, q to quit, c to continue without paging--
#96 0x00007ffff4685565 in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#97 0x00007ffff462c4db in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#98 0x00007ffff4634246 in QCoreApplication::exec() () at /lib/x86_64-linux-gnu/libQt5Core.so.5
#99 0x0000555555e2a5ed in main(int, char**) (argc=<optimized out>, argv=0x7fffffffdf98) at /home/tymon/kritadev/krita/krita/main.cc:663

Comment 1 Will Stephenson 2021-12-14 14:21:29 UTC

Were you able to reproduce this again since? I was unable to reproduce this doing as you describe with 5.0.0beta5.

Comment 2 Halla Rempt 2022-06-28 09:03:04 UTC

I don't think we can actually do much with this report. It's not reproducible for me either.