| Summary: | Brush outline is invisible | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | acc4commissions |
| Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | halla, lynx.mw+kde, tomtomtomreportingin |
| Priority: | NOR | Keywords: | triaged |
| Version First Reported In: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | All | ||
| Latest Commit: | https://invent.kde.org/graphics/krita/commit/ff618287103a559c473c9cc96a33caf1dd741a5c | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
acc4commissions
2021-04-02 10:05:04 UTC
Sorry, but I cannot reproduce that. And there have been no changes in any code related to the cursor for ages. Are you sure the outline shape setting is still set to Preview Outline. Yes, and basically all outlines are invisible including Circle outline and Tilt outline. Checking Use effective outline size didn't help either. It was visible in the last nightly : git 1b3b197 No... I cannot reproduce this on any of my Windows systems. Interestingly it is visible when I'm holding shift key to resize the outline. WARNING: The system information file doesn't exist.File name and location: C:/Users/owner/AppData/Local/krita-sysinfo.log------------------------------------
Krita
Version: 5.0.0-prealpha
Qt
Version (compiled): 5.12.9
Version (loaded): 5.12.9
OS Information
Build ABI: x86_64-little_endian-llp64
Build CPU: x86_64
CPU: x86_64
Kernel Type: winnt
Kernel Version: 10.0.19042
Pretty Productname: Windows 10 (10.0)
Product Type: windows
Product Version: 10
OpenGL Info
Vendor: "Google Inc."
Renderer: "ANGLE (NVIDIA GeForce GTX 1060 6GB Direct3D11 vs_5_0 ps_5_0)"
Version: "OpenGL ES 3.0 (ANGLE 2.1.0.57ea533f79a7)"
Shading language: "OpenGL ES GLSL ES 3.00 (ANGLE 2.1.0.57ea533f79a7)"
Requested format: QSurfaceFormat(version 3.0, options QFlags<QSurfaceFormat::FormatOption>(DeprecatedFunctions), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples -1, swapBehavior QSurfaceFormat::DoubleBuffer, swapInterval 0, colorSpace QSurfaceFormat::DefaultColorSpace, profile QSurfaceFormat::CompatibilityProfile)
Current format: QSurfaceFormat(version 3.0, options QFlags<QSurfaceFormat::FormatOption>(), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples 0, swapBehavior QSurfaceFormat::DefaultSwapBehavior, swapInterval 0, colorSpace QSurfaceFormat::DefaultColorSpace, profile QSurfaceFormat::NoProfile)
Version: 3.0
Supports deprecated functions false
is OpenGL ES: true
QPA OpenGL Detection Info
supportsDesktopGL: true
supportsAngleD3D11: true
isQtPreferAngle: true
Hardware Information
Memory: 31 Gb
Cores: 16
Swap: C:/Users/owner/AppData/Local/Temp
I can reproduce this, and it was also mentioned by Lynx in the IRC. Although the preview outline appears on startup, making a stroke is enough to make it disappear. Selecting a new tool like the rectangle tool will bring it back, but switching back to the old tool will not bring it back, along with breaking it for the rectangle tool for the rest of the session. Also, when creating a new document, the system cursor doesn't change into the canvas cursor until a stroke is made... Not sure if that's the same issue here, but that's not how it is in stable Krita. I just bisected the problem, result:
e97414d541bd9de8e080cf4cee0ce3d2c9ab1973 is the first bad commit
commit e97414d541bd9de8e080cf4cee0ce3d2c9ab1973
Author: Ivan Yossi
Date: Thu Apr 1 10:38:19 2021 -0600
Add an extra check before performing an action
we can never be sure the action is performed before
the pointer is null on macos. this is because changes
related to eea1fc28ac6c55a2d0eea1fc28ac6c55a2d0 on the
global listener.
libs/ui/canvas/kis_tool_proxy.cpp | 3 +++
1 file changed, 3 insertions(+)
Git commit ff618287103a559c473c9cc96a33caf1dd741a5c by Ivan Yossi. Committed on 05/04/2021 at 00:48. Pushed by ivany into branch 'master'. Revert "Add an extra check before performing an action" This reverts commit e97414d541bd9de8e080cf4cee0ce3d2c9ab1973. M +0 -3 libs/ui/canvas/kis_tool_proxy.cpp https://invent.kde.org/graphics/krita/commit/ff618287103a559c473c9cc96a33caf1dd741a5c |