| Summary: | Can the output file take hostname into account? | ||
|---|---|---|---|
| Product: | [Applications] Heaptrack | Reporter: | Hui Wang <hui.wang> |
| Component: | general | Assignee: | Milian Wolff <mail> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Other | ||
| Latest Commit: | https://invent.kde.org/sdk/heaptrack/commit/22e7a9cd9c028d7da9aaabad0b691f1b56f325d3 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Hui Wang
2021-03-31 18:01:21 UTC
yes that sounds like a good idea. in general improving the ability to define the file name would be welcome. are you willing to provide a patch? It should be fairly easy to do. see existing code in src/track/heaptrack.sh.cmake which handles the `-o` switch. Hi Milian, Sure, I can do the pull request. Do you want the default output file name being suffix'ed with hostname as well, for example do the following change? - output=$(pwd)/heaptrack.$(basename "$client").$$ + output=$(pwd)/heaptrack.$(basename "$client").$(hostname).$$ no I'd like to keep the current format and only allow %h and %p and similar as place holders in the `-o` parameter and then they should get replaced by the hostname, pid or whatever else we may want to add in the future. Git commit 22e7a9cd9c028d7da9aaabad0b691f1b56f325d3 by Milian Wolff, on behalf of Jacob King. Committed on 07/04/2021 at 07:16. Pushed by mwolff into branch 'master'. feat: output file name under -o can include %h and %g M +11 -1 src/track/heaptrack.sh.cmake https://invent.kde.org/sdk/heaptrack/commit/22e7a9cd9c028d7da9aaabad0b691f1b56f325d3 |