Summary: | Baloo crashes often with ASSERT(!url.endsWith('/')) | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-baloo | Reporter: | Oded Arbel <oded> |
Component: | Baloo File Daemon | Assignee: | Stefan BrĂ¼ns <stefan.bruens> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | baloo-bugs-null, nate, tagwerk19 |
Priority: | NOR | ||
Version: | 5.80.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/frameworks/baloo/commit/96284739b4b63110113af0ba7dedfd18c4459063 | Version Fixed In: | 5.82 |
Description
Oded Arbel
2021-03-30 11:16:59 UTC
While I already had the source code open, maybe this simple change will be acceptable: https://invent.kde.org/frameworks/baloo/-/merge_requests/47 Git commit 96284739b4b63110113af0ba7dedfd18c4459063 by Nate Graham, on behalf of Oded Arbel. Committed on 21/04/2021 at 17:46. Pushed by ngraham into branch 'master'. Do not crash when a dir is move/delete is detected by kinotify It appears that sometimes with kinotify sends a directory move or delete event, it may be sent with a trailing slash on the path - and this causes filewatch to fire an assertion. Instead we might expect that things like that happen and just avoid tacking on the required trailing slash ourselves. M +2 -4 src/file/filewatch.cpp https://invent.kde.org/frameworks/baloo/commit/96284739b4b63110113af0ba7dedfd18c4459063 (In reply to Nate Graham from comment #2) > https://invent.kde.org/frameworks/baloo/commit/ > 96284739b4b63110113af0ba7dedfd18c4459063 If the idea is: // Directories must always end with a trailing slash '/' then I think you are probably not meaning this: if (isDir && url.endsWith(QLatin1Char('/'))) { url.append(QLatin1Char('/')); } (In reply to tagwerk19 from comment #3) > then I think you are probably not meaning this: > > if (isDir && url.endsWith(QLatin1Char('/'))) { > url.append(QLatin1Char('/')); > } You are correct. This has also been pointed out by other people. I'm working on fixing this. The last issue was fixed in https://invent.kde.org/frameworks/baloo/-/commit/dc04879f058dd1eab72e4bd4c80bdc1ea3c06c9b @tagwerk19, thanks for noticing. |