Bug 434875

Summary:	README instructions may not be complete/correct for android build
Product:	[Applications] kirigami gallery	Reporter:	Ludovic Jozeau <unifai>
Component:	general	Assignee:	Marco Martin <notmart>
Status:	REPORTED ---
Severity:	normal	CC:	wincak
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Android
OS:	Android 7.x
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Ludovic Jozeau 2021-03-24 11:26:44 UTC

SUMMARY

I think the `make install` step is missing in the readme, it's required for instance to install the icons to a dummy place later fetched by androiddeployqt (I'm also wondering why all those complex step are required, couldn't we just copy the icons directly in the build directory? Thus avoiding the make install step).

https://invent.kde.org/sdk/kirigami-gallery/-/blob/master/README.md

Second issue is `-DANDROID_APK_DIR=./src/`, shouldn't that be pointing to the src/android directory? In order to get the AndroidManifest.xml and res/ dir where there is the app icon? For me the app didn't have its icon unless I invoke cmake with `-DANDROID_APK_DIR="$PWD/../src/android"` when I'm in project_root/build.

hope that will help :)

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.21.3
KDE Frameworks Version: 5.80
Qt Version: 5.15.2

ADDITIONAL INFORMATION

Comment 1 wincak 2021-04-02 17:04:03 UTC

The build instructions definitely aren't good enough, I'm struggling to build Kirigami for Android for a pretty long time now (https://bugs.kde.org/show_bug.cgi?id=431031)

(In reply to federandink from comment #0)
Did you manage to build and deploy the Gallery in the end? If yes, could you write down better instructions? I would really appreciate it because I always get lost in CMake errors (on current KDE Neon)...

Comment 2 Nate Graham 2022-07-12 19:07:56 UTC

*** Bug 431031 has been marked as a duplicate of this bug. ***