Bug 434827

Summary: Allow disabling "click on label to rename" feature when using double-click mode
Product: [Plasma] plasmashell Reporter: popov895 <popov895>
Component: FolderAssignee: Eike Hein <hein>
Severity: wishlist CC: nate, plasma-bugs, popov895
Priority: NOR    
Version: 5.21.3   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=392731
Latest Commit: Version Fixed In: 5.22

Description popov895 2021-03-23 10:53:49 UTC

Currently, clicking on the caption of the selected item turns on its inline renaming, which often leads to accidental activation of this feature. It would be nice to have an option to turn this feature on or off (same as in Dolphin). It would also be nice that if this feature is turned off, then the file is renamed in a separate window (same as in Dolphin). Additionally, bulk renaming doesn't work.


Linux/KDE Plasma: openSUSE Tumbleweed 20210320 / X11
KDE Plasma Version: 5.21.3
KDE Frameworks Version: 5.80.0
Qt Version: 5.15.2
Comment 1 Nate Graham 2021-03-23 13:12:18 UTC
So do I understand that you are using Double-Click mode but do *not* want to use the inline renaming functionality?
Comment 2 popov895 2021-03-23 13:47:55 UTC
Yes, I use double click mode and also prefer to use F2 shortcut to rename items.
Comment 3 Nate Graham 2021-03-23 15:08:07 UTC

We have three options, each with a disadvantage:
1. Add an option in the Folder View Icons configuration page (boo, more options most people will never use)
2. Read the value of Dolphin's option (boo, non-obvious option inheritance)
3. Do nothing and close this as RESOLVED INTENTIONAL (boo, ignoring users and having inconsistencies between the different file view implementations
Comment 4 popov895 2021-03-23 15:34:37 UTC
And the fourth option: move this setting to System Settings (System Settings > Workspace Behavior > General Behavior), as it's done for the "Clicking files and folders" option.
Comment 5 Nate Graham 2021-03-23 16:16:54 UTC
That I fear would be rather misleading, since we don't have a click-to-rename feature anywhere else right now. So it could mislead users into thinking that the feature worked in contexts where it does not.
Comment 6 popov895 2021-03-23 16:27:36 UTC
Well, then I vote for the first option because the preview settings are also separated between Folder View Icons and Dolphin.
Comment 7 Bug Janitor Service 2021-03-23 17:07:11 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/392
Comment 8 Nate Graham 2021-04-08 20:22:08 UTC
Git commit 9574fbb6dd4fc3a42539d88ae7a6f1178dfb4560 by Nate Graham.
Committed on 08/04/2021 at 20:21.
Pushed by ngraham into branch 'master'.

[folder view] Allow disabling click-to-rename when using double-click

a911982efce3efeb510899abb526230b0de12f7f added a "Click on the label to
initiate renaming when using double-click" feature, mimicking the one
that Dolphin has. However Dolphin also has an option to turn it off,
while Folder View thus far does not.

This commit implements a simple setting to turn it off, placed in the
same place in Folder View's config window as the equivalent Dolphin
option. Ths option is not visible and has no effect when using the
default single-click mode.
FIXED-IN: 5.22

M  +4    -0    containments/desktop/package/contents/config/main.xml
M  +8    -0    containments/desktop/package/contents/ui/ConfigIcons.qml
M  +1    -0    containments/desktop/package/contents/ui/FolderView.qml